fix traces tests

lumigo-io · Dec 22, 2024 · 5b96457 · 5b96457
1 parent d17286c
commit 5b96457
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 6 deletions.
diff --git a/tests/kubernetes-distros/kind/lumigooperator_traces_test.go b/tests/kubernetes-distros/kind/lumigooperator_traces_test.go
@@ -40,10 +40,10 @@ func TestLumigoOperatorTraces(t *testing.T) {
 
 	deploymentName := "app"
 	cronJobName := "load-generator"
+	namespaceName := envconf.RandomName("test-ns", 12)
 
 	testAppDeploymentFeature := features.New("TestApp").
-	Setup(func(ctx context.Context, t *testing.T, config *envconf.Config) context.Context {
-			namespaceName := envconf.RandomName(ctx.Value(internal.ContextTestAppNamespacePrefix).(string), 12)
+		Setup(func(ctx context.Context, t *testing.T, config *envconf.Config) context.Context {
 			testJsAppClientImage := ctx.Value(internal.ContextTestAppJsClientImageName).(string)
 			testJsAppServerImage := ctx.Value(internal.ContextTestAppJsServerImageName).(string)
 
@@ -242,7 +242,6 @@ func TestLumigoOperatorTraces(t *testing.T) {
 			return ctx
 		}).
 		Assess("CronJob traces have the 'k8s.cronjob.id' resource attribute set", func(ctx context.Context, t *testing.T, c *envconf.Config) context.Context {
-			namespaceName := envconf.RandomName(ctx.Value(internal.ContextTestAppNamespacePrefix).(string), 12)
 			otlpSinkDataPath := ctx.Value(internal.ContextKeyOtlpSinkDataPath).(string)
 
 			tracesPath := filepath.Join(otlpSinkDataPath, "traces.json")
@@ -313,7 +312,6 @@ func TestLumigoOperatorTraces(t *testing.T) {
 			return ctx
 		}).
 		Assess("Deployment traces have the 'k8s.deployment.uid' resource attribute set", func(ctx context.Context, t *testing.T, c *envconf.Config) context.Context {
-			namespaceName := envconf.RandomName(ctx.Value(internal.ContextTestAppNamespacePrefix).(string), 12)
 			otlpSinkDataPath := ctx.Value(internal.ContextKeyOtlpSinkDataPath).(string)
 
 			tracesPath := filepath.Join(otlpSinkDataPath, "traces.json")
@@ -556,7 +554,6 @@ func TestLumigoOperatorTraces(t *testing.T) {
 			return ctx
 		}).
 		Assess("LUMIGO_ENABLE_TRACES reflects spec.tracing.enabled", func(ctx context.Context, t *testing.T, c *envconf.Config) context.Context {
-			namespaceName := envconf.RandomName(ctx.Value(internal.ContextTestAppNamespacePrefix).(string), 12)
 			if err := apimachinerywait.PollImmediateUntilWithContext(
 				ctx,
 				time.Second*5,

diff --git a/tests/kubernetes-distros/kind/main_test.go b/tests/kubernetes-distros/kind/main_test.go
@@ -209,7 +209,7 @@ func TestMain(m *testing.M) {
 	ctx = context.WithValue(ctx, internal.ContextTestAppPythonImageName, testPythonImageName)
 	ctx = context.WithValue(ctx, internal.ContextTestAppBusyboxIncludedContainerNamePrefix, "busybox-included")
 	ctx = context.WithValue(ctx, internal.ContextTestAppBusyboxExcludedContainerNamePrefix, "busybox-excluded")
-	ctx = context.WithValue(ctx, internal.ContextTestAppNamespacePrefix, "test-ns")
+	ctx = context.WithValue(ctx, internal.ContextTestAppNamespacePrefix, "test-logs-ns")
 
 	testEnv = env.NewWithConfig(cfg).WithContext(ctx)