Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RD-12747 - document the secret scrubbing behavior #69

Merged
merged 4 commits into from
Jun 9, 2024
Merged

RD-12747 - document the secret scrubbing behavior #69

merged 4 commits into from
Jun 9, 2024

Conversation

harelmo-lumigo
Copy link
Contributor

No description provided.

sagivoululumigo
sagivoululumigo reviewed Jun 4, 2024
View reviewed changes
README.md Outdated Show resolved Hide resolved
sagivoululumigo
sagivoululumigo reviewed Jun 4, 2024
View reviewed changes
README.md Outdated Show resolved Hide resolved
sagivoululumigo
sagivoululumigo reviewed Jun 4, 2024
View reviewed changes
README.md Outdated Show resolved Hide resolved
sagivoululumigo
sagivoululumigo reviewed Jun 4, 2024
View reviewed changes
README.md Outdated Show resolved Hide resolved
@codecov Codecov
Copy link

codecov bot commented Jun 4, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.33%. Comparing base (9252fa5) to head (4fc23a9).
Report is 1 commits behind head on master.

Additional details and impacted files 
@@             Coverage Diff              @@
##             master      #69      +/-   ##
============================================
- Coverage     79.47%   78.33%   -1.14%     
  Complexity      436      436              
============================================
  Files            48       49       +1     
  Lines          1993     2022      +29     
  Branches        213      213              
============================================
  Hits           1584     1584              
- Misses          329      358      +29     
  Partials         80       80

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

harelmo-lumigo
harelmo-lumigo commented Jun 4, 2024
View reviewed changes
README.md Outdated Show resolved Hide resolved
sagivoululumigo
sagivoululumigo requested changes Jun 5, 2024
View reviewed changes
Copy link

@sagivoululumigo sagivoululumigo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some notes

@harelmo-lumigo
Copy link
Contributor Author

Left some notes

I've addressed all the concerns in a rephrased section. Please LMK what you think.

@harelmo-lumigo harelmo-lumigo merged commit add1397 into master Jun 9, 2024
11 of 12 checks passed
lumigo-circleci-github-user pushed a commit that referenced this pull request Jun 9, 2024
1.0.45 → 1.0.46. Changes: add1397 RD-12747 - document the secret scru…
ccb259e 
…bbing behavior (#69)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sagivoululumigo sagivoululumigo sagivoululumigo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@harelmo-lumigo @sagivoululumigo