Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix scan aspect ratio #589

Merged
merged 1 commit into from
Oct 31, 2023
Merged

Fix scan aspect ratio #589

merged 1 commit into from
Oct 31, 2023

Conversation

rpauszek
Copy link
Contributor

Why this PR?
We currently calculate a default aspect ratio which results in square pixels. For scans acquired with non-square pixels, this results in distortion of the image

Current:
Screenshot 2023-10-31 at 15 05 56

Fixed:
Screenshot 2023-10-31 at 15 06 38

This aspect ratio always resulted in square pixels and thus distortion of images acquired with non-square pixel settings
@rpauszek rpauszek requested review from a team as code owners October 31, 2023 14:15
Copy link
Member

@JoepVanlier JoepVanlier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but maybe add an example to the docstring showing the use of aspect="equal" for people who want the square pixels back?

wide

@rpauszek
Copy link
Contributor Author

Looks good, but maybe add an example to the docstring showing the use of aspect="equal" for people who want the square pixels back?

I thought about this, but I truly can't think of a use case where you'd actually want to do this. Even in the case where users have started analysis and want consistency, I truly think everyone would rather just re-plot and get the correct image than force a messed up one, no?

@JoepVanlier
Copy link
Member

Looks good, but maybe add an example to the docstring showing the use of aspect="equal" for people who want the square pixels back?

I thought about this, but I truly can't think of a use case where you'd actually want to do this. Even in the case where users have started analysis and want consistency, I truly think everyone would rather just re-plot and get the correct image than force a messed up one, no?

👍

@rpauszek rpauszek merged commit d4c7c40 into release/1.2 Oct 31, 2023
8 checks passed
@rpauszek rpauszek deleted the fix_scan_aspect branch October 31, 2023 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants