force_calibration: split low-level fit from preparation and packaging #588
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoepVanlier
force-pushed
the
split_calibration
branch
from
2bbe1e9 to
122c6a1
Compare
JoepVanlier
force-pushed
the
split_calibration
branch
from
122c6a1 to
d059f20
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this PR?
Currently, you can only use the spectral density fitting as part of one single function that prepares the initial guess, fits the spectrum and then packages the result.
This prohibits coming up with more advanced fitting schemes such as combining multiple datasets into a single fit or using priors. This PR splits the actual fitting procedure from the public API and allows more general models to be fitted by the internal function.