Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Check for null profile names #26

Merged
merged 1 commit into from
Nov 14, 2024
Merged

fix: Check for null profile names #26

merged 1 commit into from
Nov 14, 2024

Conversation

Wolmin
Copy link

@Wolmin Wolmin commented Nov 7, 2024

Description and Related Issue(s)

Added a null handling for profile response. This fixes invalid responses from search bar

Proposed Changes

Breaking or Incompatible Changes

Additional Information

Checklist for PR author

  • I have tested these changes locally.
  • I added tests to cover any new functionality, following this guide
  • Whenever I fix a bug, I include a regression test to ensure that the bug does not reappear silently.
  • If I have added, changed, renamed, or removed an environment variable
    • I updated the list of environment variables in the documentation
    • I made the necessary changes to the validator script according to the guide
    • I added "ENVs" label to this pull request

@Wolmin Wolmin added the bug Something isn't working label Nov 7, 2024
@Wolmin Wolmin requested a review from richtera November 7, 2024 11:53
@Wolmin Wolmin self-assigned this Nov 7, 2024
Copy link
Collaborator

@mxmar mxmar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm @Wolmin

@richtera you can review tomorrow 👍

@Wolmin Wolmin merged commit c9bc4b1 into lukso Nov 14, 2024
9 of 12 checks passed
@Wolmin Wolmin deleted the fix/0-search branch November 14, 2024 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Development

Successfully merging this pull request may close these issues.

2 participants