Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: search ups by name #10

Merged
merged 9 commits into from
Dec 7, 2023
Merged

Feature: search ups by name #10

merged 9 commits into from
Dec 7, 2023

Conversation

Wolmin
Copy link

@Wolmin Wolmin commented Dec 4, 2023

This PR adds a feature where blockscout users are able to search Universal Profiles by the name, not only by the full address.

@Wolmin Wolmin added the enhancement New feature or request label Dec 4, 2023
@Wolmin Wolmin requested a review from Hugoo December 4, 2023 14:13
@Wolmin Wolmin self-assigned this Dec 4, 2023
@Wolmin Wolmin requested review from richtera and mxmar December 6, 2023 14:56
mxmar
mxmar approved these changes Dec 6, 2023
View reviewed changes
Copy link
Collaborator

@mxmar mxmar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @Wolmin

I'd be the best if @Hugoo or @richtera can verify TS code as well 👍

@mxmar
Copy link
Collaborator

mxmar commented Dec 7, 2023

LGTM @Wolmin

I'd be the best if @Hugoo or @richtera can verify TS code as well 👍

@Wolmin Does it require to update documentation files? If yes, please update them ⚠️ (README or ENVS)

@Wolmin Wolmin merged commit 586da81 into lukso Dec 7, 2023
3 of 6 checks passed
@Wolmin Wolmin deleted the feature/search-ups branch December 7, 2023 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mxmar mxmar mxmar approved these changes

@Hugoo Hugoo Awaiting requested review from Hugoo

@richtera richtera Awaiting requested review from richtera

Assignees

@Wolmin Wolmin

Labels
enhancement New feature or request
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Wolmin @mxmar