Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add Headers for api call #23

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

fuergaosi233
Copy link

image
In the latest Gitlab API interface, you need to bring the Token into the headers to make the call.This solves my 403 problem.

Change-Id: Ibd348a50ad30faecfb9b104e470ddb3ebefede8e
@lukewaite
Copy link
Owner

@fuergaosi233 Thanks for the PR! Are you able to clarify what you're attempting to solve for here?

I just updated our install to 13.4.1 to test, and auth is still working for me without any code changes. Further, the API docs seem to indicate that query-string based authentication is still supported.

https://docs.gitlab.com/ee/api/#personalproject-access-tokens

I'm certainly not against moving to the header, since it is a better option that I can only assume was perhaps not supported when the workflow was originally written, but would like to understand if there's an issue at play here.

@fuergaosi233
Copy link
Author

@lukewaite Sorry, I don't konw why it's not work.If I didn't make the change then it won't work, I'm using my company's Gitlab so I don't know its version number.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants