-
-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use absolute version to install nightly and rc #40
base: master
Are you sure you want to change the base?
Conversation
Thanks for working on this, you can piggy back on existing e.g: $ NVM_NODEJS_ORG_MIRROR=https://nodejs.org/download/nightly/ nvm ls-remote
v0.10.41-nightly20151203036580393d
v0.10.42-nightly20160128b125512a5c
...
v9.1.1-nightly201711075f5ef4226e
v10.0.0-nightly20171126bb4462681c |
Alright.. I will work on this tonight.. and rebase the PR |
One issue I noticed is that, So I need to handle that in parsing logic too.. :\ |
@lukechilds I felt copying the functions from |
I've re-used nvm functions wherever possible to keep the codebase to minimum and reduce code duplication. It should be fairly simple to parse |
@lukechilds I've used
Installing the nighltly from scratch works fine.. I guess we could check whether the installed version is latest by ourselves instead of calling Sigh.. |
Does this definitely resolve the problem for you? I still get the nightly aliases:
|
You have to manually clear the alias if you once used the older hack.
|
POSIX sed doesn't do non-greddy match so we just pipe it to awk. This will handle cases when the latest nighlty version is installed or not. Command tested with. echo "v10.0.0-nightly20171126bb4462681c (test)" \ | sed -n "s/.*\(v.*\)/\1/p" | awk '{print $1}' echo "-> v10.0.0-nightly20171126bb4462681c (test)" \ | sed -n "s/.*\(v.*\)/\1/p" | awk '{print $1}'
Tested to install latest nightly.
The version_list code is copy pasta from nvm sauce with slight modification
However I couldnt copy pasta the nvm_download function.. which has lot of internal stuffs.
So, I just used curl for now.
EDIT: Rebased to update commit message.
Alias seems to be fine too..