Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incompatibility with latest InversifyJS #1718

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

helios-ag
Copy link

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you written unit tests?
  • Have you written unit tests that cover the negative cases (i.e.: if bad data is submitted, does the library respond properly)?
  • This PR is associated with an existing issue?

Closing issues

Closes #1717

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello there helios-ag 👋

Thank you and congrats 🎉 for opening your first PR on this project.✨

We will review the following PR soon! 👀

@helios-ag
Copy link
Author

@WoH @jackey8616 bump

@amt8u
Copy link

amt8u commented Nov 25, 2024

@dgreene1 @lukeautry bump. The PR is open for sometime now.

@helios-ag
Copy link
Author

A bit weird, that GHA fails...

@helios-ag
Copy link
Author

@WoH bump

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incompatibility with recent versions of inversifyJS
2 participants