Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix disable validation #88

Merged
merged 4 commits into from
Oct 24, 2023
Merged

Fix disable validation #88

merged 4 commits into from
Oct 24, 2023

Conversation

luigibonati
Copy link
Owner

Description

This PR fixes #83

Todos

I changed the DictModule as to accept a list with just one split. Furthermore, since by default the trainer expects a validation loader, it has to be disabled in the trainer options (see Lightning-AI/pytorch-lightning#12374)
I added these instructions in the tutorial on how to customize training

Status

  • Ready to go

@luigibonati luigibonati requested a review from andrrizzi July 9, 2023 23:21
@codecov
Copy link

codecov bot commented Jul 9, 2023

Codecov Report

Merging #88 (2a43254) into main (88b0189) will decrease coverage by 0.04%.
Report is 4 commits behind head on main.
The diff coverage is 83.33%.

Copy link
Collaborator

@andrrizzi andrrizzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@luigibonati
Copy link
Owner Author

luigibonati commented Jul 25, 2023

I did not merge this yet as I realized there is an issue with the logging, in that the MetricsCallback that I wrote is called only at the end of validation, so it does not log the training values. needs to fix that before merging

https://github.com/luigibonati/mlcolvar/blob/e356f2436568ca0361ec227cef3c33e332959bf0/mlcolvar/utils/trainer.py#L29C11-L29C11

@luigibonati luigibonati merged commit f948417 into main Oct 24, 2023
11 checks passed
@luigibonati
Copy link
Owner Author

I fixed the issue by changing the moment in which the callback is called (at the end of the training and not validation), merging it now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Training without validation set crashes
2 participants