Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Committor updates #151

Merged
merged 32 commits into from
Sep 27, 2024
Merged

Committor updates #151

merged 32 commits into from
Sep 27, 2024

Conversation

EnricoTrizio
Copy link
Collaborator

@EnricoTrizio EnricoTrizio commented Sep 20, 2024

Description

Adds a few new functionalities to committor code:

  • Use of separate datasets for the training (i.e., boundary and variational) via the separate_boundary_dataset key
  • Function to precompute the derivatives of descriptors wrt position for faster and cheaper evaluation via the SmartDerivatives class and the descriptors_derivatives key. This required an unpdate of the requirements.txt to include torch-scatter but it's easy in pip and only affects the Python code (i.e., no need to trace it nor change anything on the PLUMED side)
  • Better implementation of PairwiseDistances for selected pairs with slicing_pairs key
  • Added the possibility of passing the colors kwarg to the plot_isolines_2D function rather than using a greys only for contour mode
  • Moved committor tutorial to the tutorials
  • Created committor example when computing descriptors using alanine
  • Improved tests

Additionally it also fixes some late issues with micromamba, see #155. In detail:

TODO

  • New test for committor using also alanine and the preprocessing + smart derivatives

Status

  • Ready to go

@EnricoTrizio EnricoTrizio added the enhancement New feature or request label Sep 20, 2024
Copy link

codecov bot commented Sep 25, 2024

Codecov Report

Attention: Patch coverage is 96.90722% with 6 lines in your changes missing coverage. Please review.

Project coverage is 92.75%. Comparing base (69e702e) to head (65f9b6e).
Report is 33 commits behind head on main.

Additional details and impacted files

@EnricoTrizio EnricoTrizio merged commit ecf5c69 into main Sep 27, 2024
12 checks passed
@EnricoTrizio EnricoTrizio deleted the smart_derivatives branch September 27, 2024 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant