Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Register TDA target parameters as loss module buffers #142

Merged
merged 2 commits into from
Jun 11, 2024

Conversation

recisic
Copy link
Contributor

@recisic recisic commented Jun 8, 2024

Description

This PR introduces registration of the TDA target parameters (target_centers and target_sigmas) as buffers within the TDALoss module.

  • Eliminates the need to convert both parameters to tensors and move them to the current device for each loss calculation step
  • Enables retrieval of target parameters from saved DeepTDA CV checkpoints or traced modules

Status

  • Ready to go

@EnricoTrizio
Copy link
Collaborator

Ciao Juno, that looks great! I'll merge and close. Thanks for the help 🚀

@EnricoTrizio EnricoTrizio merged commit 78387c7 into luigibonati:main Jun 11, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants