-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extension of transform module #124
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! I've left a few comment but it's only nitpicking.
For the structure, it looks ok to me, but I'd tend to have the least possible number of packages/modules called tools
or utils
. I might be missing the rationale here though. I usually use tools essentially as synonym for utils meaning "anything I don't know where else to put/how else to organize".
Maybe we could simply move all the transform/tools/*.py
modules directly in transform/*.py
. Some of the elements (like Inverse
or Statistics
) might deserve their own inverse.py
or statistics.py
module. This is mostly taste anyway. It might not be the prettiest structure to have a bunch of small modules inside a package but I usually find it helpful when I navigate codebases.
Description
Adding some preprocessing tools to the transform module, including descriptors computation and tools.
NB-1 Transform object are supposed not to have trainable parameters.
NB-2 Position-dependent descriptors are implemented only for cubic/orthorhombic cells.
The structure of the module is:
Tools
Descriptors, acting on positions
Already implemented but likely to be kept out of this PR:
Status