-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add sensitivity analysis #108
Conversation
In order to automatically retrieve the input descriptors names I added an attribute |
return_ax = False | ||
|
||
# define utils functions | ||
def _set_violin_attributes(violin_parts, color, alpha=0.5, label=None, zorder=None): |
Check notice
Code scanning / CodeQL
Explicit returns mixed with implicit (fall through) returns Note
I would prefer to have the plots horizontally rather than vertically, please fix this @luigibonati 🤗 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
Hello! Thank you for providing the sensitivity analysis code. We have tested it and found its performance to be excellent. However, we encountered an issue during the simplification of our system's 4536 descriptors, specifically regarding the image size being too large. In particular, we received the following error message: |
hi, thanks for the feedback. i added a tutorial in the documentation where i show how to customize the analysis. it should work now, let me know!
|
@@ -256,6 +256,160 @@ | |||
else: | |||
return None | |||
|
|||
|
|||
def plot_sensitivity(results, mode="violin", per_class=None, max_features = 100, ax=None): |
Check notice
Code scanning / CodeQL
Explicit returns mixed with implicit (fall through) returns Note
Hello! Thank you for providing your tutorial and the new code. We've adapted and executed DeepTICA (our protein-ligand system) based on your DeepLDA tutorial. We successfully plotted sensitivity, but encountered an issue when attempting to create a new dataset using only the first N features, as indicated below: Could you please guide us on how to modify it to suit DeepTICA data? |
The features are sorted in ascending order, this is why we need to slice the last N features instead of the first ones. Regarding the error in creating the new dataset, it is related to the fact that in the case of a time-lagged dataset (at variance with those created with the let me know if this works
I will add a warning that the feature names could not be retrieved if they are not present in the dataset. Luigi |
Thank you for providing the new code, it works and I get the new deep-TICA(.tpc) model. I find this error perplexing, and I was hoping you could assist me in troubleshooting or provide any guidance on resolving this matter. I have attached relevant files such as plumed.dat, .tpr, .tpc, descriptors.dat, and a log for your reference. Best regards, |
Description
Add a sensitivity analyisis as done in the DeepLDA/DeepTICA paper, as requested in #105.
Todos
sensitivity_analysis
inutils.explain
plot_sensitivity_analysis
inutils.plot
For now I created a new module inside utils called
explain
, altough we might also move it outside utils and create an explain module which contains this together with other things such as the sparse classification with Lasso (@pietronvll)