-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: test thread-safety #65
base: master
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #65 +/- ##
=======================================
Coverage 58.83% 58.83%
=======================================
Files 8 8
Lines 566 566
=======================================
Hits 333 333
Misses 233 233 ☔ View full report in Codecov by Sentry. |
Thanks for the PR! |
This way, we should be able to reproduce the failing threading tests
Add CI for arm64 Mac
I forgot to make sure the tests actually run with multiple threads. Now, the segmentation fault on the Mac is back - besides additional errors which I have to investigate further! |
Actually, this one seems to be ready - I have rerun the failing test on Ubuntu and it went smoothly. Now, only the multithreading tests on MacOS fail, probably due to some OpenMP issue that I have not been able to identify yet. |
Do the tests pass if you sync this PR with master, so that it includes your fix for FFTW thread safety? |
I have played around with some more CI tweaks; however, the FFTW thread-safety adaptations do not help with the issues on MacOS... |
Ok. I don't think we should merge this as long as it's failing in the CI. We could hold off with it until a fix is in place, and then merge it in so that we can detect any future regression on the thread safety. Or just disable the test on MacOS for now, but then we would need to remember to turn it back on. |
Sounds good! Then, let's keep this PR open until the MacOS issue has been resolved. |
This PR adds a basic test for the thread-safety of FINUFFT in julia. According to #63 , this test fails on MacOS but not on Windows or Linux.