update readme to support running fusion on local k8s cluster #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mllu
commented
Feb 14, 2020
•
mllu
commented
- Update readme to support running fusion on local k8s cluster
mllu
force-pushed
the
mllu/support_local_kind_k8s
branch
2 times, most recently
from
b2ba580 to
3819ec2
Compare
mllu
force-pushed
the
mllu/support_local_kind_k8s
branch
from
3819ec2 to
c708970
Compare
mllu
commented
Feb 14, 2020
thelabdude
suggested changes
Feb 16, 2020
thelabdude
reviewed
Feb 17, 2020
thelabdude
reviewed
Feb 17, 2020
thelabdude
reviewed
Feb 17, 2020
mllu
commented
Feb 17, 2020
| @@ -16,6 +16,7 @@ FORCE=0 | |||
| CUSTOM_MY_VALUES=() | |||
| MY_VALUES=() | |||
| DRY_RUN="" | |||
| SOLR_REPLICAS=1 | |||
There was a problem hiding this comment.
SOLR_REPLICAS is a variable used below without default value, default to 1 here, let me know if it's intended to not have default value
mllu
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.