Upgrade to Bazel 8 #78
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 10 commits
January 17, 2025 13:30
These were sourced from the Bazel 8 release page: https://github.com/bazelbuild/bazel/releases/tag/8.0.0
Bazel 8 deprecates the rulesets bundled with Bazel (which includes the Protobuf rules) in favor of their Starlark-ified equivalents. For that reason, we switch to the `protobuf` ruleset for `proto_library` and `java_proto_library`. In doing so, we can't use `com.github.os72:protoc-jar` because the version of protoc it bundles is extremely out of date and incompatible with the version of protobuf provided by the Starlark-ified protobuf ruleset. In its place, we use the protoc provided by that ruleset.
added 2 commits
January 22, 2025 17:27
v0.7.1 doesn't use the Starlark-ified protobuf rules.
…ction_env The former is deprecated and has been replaced with the latter.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR upgrades the ruleset to Bazel 8. It should also make the upgrade to future Bazel versions easier by enabling a number of
--incompatible_*flags. These enforce that we're not using deprecated features that will be removed in a future major Bazel version.Note that I wasn't able to enable path mapping because the same bug that prevented us from enabling it with Bazel 7 seems to be pervasive in Bazel 8 as well. I'll look into that soon; I just wanted to get us upgraded first.