Speed up ZincRunner #76
Conversation
| workRequest.compilerOptions ++ | ||
| workRequest.compilerOptionsReferencingPaths | ||
| ).toArray, | ||
| workRequest.plugins.map(p => s"-Xplugin:$p").toArray ++ |
There was a problem hiding this comment.
Is there any benefit in doing workRequest.plugins.view.map(p => s"-Xplugin:$p").toArray to avoid the construction of intermediate results?
There was a problem hiding this comment.
If so, I kind of wonder if there would be a benefit to using views in other places as well. I doubt it would be a huge win, but probably something.
There was a problem hiding this comment.
Yup, you're right; that would be more performant. I wasn't able to find any places in CommonArguments.scala where .view could be effectively utilized, but I found a few other places in ZincRunner. I'll update them.
| @@ -319,7 +312,17 @@ object ZincRunner extends WorkerMain[ZincRunnerWorkerConfig] { | |||
| infos = FilteredInfos.getFilteredInfos(originalResultAnalysis.infos), | |||
| ) | |||
| } | |||
| analysisStoreText.set(AnalysisContents.create(resultAnalysis, compileResult.setup)) | |||
|
|
|||
| if (verbosity >= 10) { | |||
There was a problem hiding this comment.
I recommend adding a comment here that says verbosity = 10 when --worker_verbose is set. Otherwise this may look like an arbitrary constant to folks who don't know that.
| .withSources(sources.map(source => PlainVirtualFile(source.toAbsolutePath().normalize())).toArray) | ||
| .withClasspath((classesOutputDir +: deps.map(_.classpath)).map(path => PlainVirtualFile(path)).toArray) | ||
| .withSources(sources.view.map(source => PlainVirtualFile(source.toAbsolutePath().normalize())).toArray) | ||
| .withClasspath((classesOutputDir +: deps.map(_.classpath)).view.map(path => PlainVirtualFile(path)).toArray) |
There was a problem hiding this comment.
Should deps.map(_.classpath)).view.map(path => PlainVirtualFile(path)).toArray) instead be deps.view.map(_.classpath)).map(path => PlainVirtualFile(path)).toArray)?
There was a problem hiding this comment.
Ah, good point. I didn't realize you could prepend to a View.
jadenPete
force-pushed
the
speed-up-zincrunner
branch
from
32f6fdc to
ba4c428
Compare
|
Rebased off of |
jadenPete
force-pushed
the
speed-up-zincrunner
branch
from
625ca3c to
4f8c6d1
Compare
|
Squashed. |
These changes cause compilation to take ~98% of
ZincRunner's time, up from ~93%—a 5% speedup.Before:
After:
