Finish review for account

lucca65 · Mar 7, 2024 · 37d5068 · 37d5068
1 parent d8200df
commit 37d5068
Show file tree

Hide file tree

Showing 3 changed files with 59 additions and 7 deletions.
diff --git a/lib/account.ex b/lib/account.ex
@@ -128,7 +128,18 @@ defmodule XRPL.Account do
     optional(:marker, :string)
 
     optional(:type, :enum,
-      values: ~w[check deposit_preauth escrow nft_offer nft_page offer payment_channel signer_list state ticket]
+      values: [
+        "check",
+        "deposit_preauth",
+        "escrow",
+        "nft_offer",
+        "nft_page",
+        "offer",
+        "payment_channel",
+        "signer_list",
+        "state",
+        "ticket"
+      ]
     )
   end
 
@@ -165,7 +176,52 @@ defmodule XRPL.Account do
   defparams "account_tx" do
     required(:account, :string, format: XRPL.account_address_regex())
 
-    optional(:tx_type, :enum, values: XRPL.transaction_types())
+    optional(:tx_type, :enum,
+      values: [
+        "AccountSet",
+        "AccountDelete",
+        "AMMBid",
+        "AMMCreate",
+        "AMMDelete",
+        "AMMDeposit",
+        "AMMVote",
+        "AMMWithdraw",
+        "CheckCancel",
+        "CheckCash",
+        "CheckCreate",
+        "Clawback",
+        "DepositPreauth",
+        "DIDDelete",
+        "DIDSet",
+        "EscrowCancel",
+        "EscrowCreate",
+        "EscrowFinish",
+        "NFTokenAcceptOffer",
+        "NFTokenBurn",
+        "NFTokenCancelOffer",
+        "NFTokenCreateOffer",
+        "NFTokenMint",
+        "OfferCancel",
+        "OfferCreate",
+        "Payment",
+        "PaymentChannelClaim",
+        "PaymentChannelCreate",
+        "PaymentChannelFund",
+        "SetRegularKey",
+        "SignerListSet",
+        "TicketCreate",
+        "TrustSet",
+        "XChainAccountCreateCommit",
+        "XChainAddAccountCreateAttestation",
+        "XChainAddClaimAttestation",
+        "XChainClaim",
+        "XChainCommit",
+        "XChainCreateBridge",
+        "XChainCreateClaimID",
+        "XChainModifyBridge"
+      ]
+    )
+
     optional(:ledger_index_min, :integer)
     optional(:ledger_index_max, :integer)
     optional(:ledger_hash, :string, format: XRPL.is_hash())

diff --git a/lib/xrpl.ex b/lib/xrpl.ex
@@ -122,8 +122,4 @@ defmodule XRPL do
   def ledger_index_regex do
     ~r/^(\d+|current|closed|validated)$/
   end
-
-  def transaction_types do
-    ~w(AccountSet AccountDelete AMMBid AMMCreate AMMDelete AMMDeposit AMMVote AMMWithdraw CheckCancel CheckCash CheckCreate Clawback DepositPreauth DIDDelete DIDSet EscrowCancel EscrowCreate EscrowFinish NFTokenAcceptOffer NFTokenBurn NFTokenCancelOffer NFTokenCreateOffer NFTokenMint OfferCancel OfferCreate Payment PaymentChannelClaim PaymentChannelCreate PaymentChannelFund SetRegularKey SignerListSet TicketCreate TrustSet XChainAccountCreateCommit XChainAddAccountCreateAttestation XChainAddClaimAttestation XChainClaim XChainCommit XChainCreateBridge XChainCreateClaimID XChainModifyBridge)
-  end
 end
diff --git a/test/account_test.exs b/test/account_test.exs
@@ -100,7 +100,7 @@ defmodule XRPL.AccountTest do
   describe "account_objects/1" do
     test "returns information about an account's objects" do
       assert {:ok, %Tesla.Env{status: 200}} =
-               Account.account_objects(@account)
+               Account.account_objects(%{account: @account})
     end
 
     test "it returns an error if we don't provide the required param" do