Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft: V6 with rmscene #59

Draft
wants to merge 59 commits into
base: master
Choose a base branch
from
Draft
Changes from 1 commit
Commits
Show all changes
59 commits
Select commit Hold shift + click to select a range
2583378
Add: Reduce number of file reads
Azeirah Dec 22, 2022
1f380a8
Add: start working on v3
Azeirah Dec 22, 2022
61d5fa1
Fix error where NoneType has no `len()`
Azeirah Dec 26, 2022
04d149a
Change no scribbles/highlights found into "warnings" rather than errors
Azeirah Dec 26, 2022
a3867d6
Add: Temporarily skip v6 .rm drawing and parsing
Azeirah Dec 26, 2022
743d259
Add: Handle edge case where .rm lines have only one point (requiring 2)
Azeirah Dec 26, 2022
525bd18
Add: Rmscene dependency
Azeirah Jan 20, 2023
f38d9c9
Refactor code a bit for rmscene v6 parsing
Azeirah Jan 20, 2023
4cc526d
Add: Meta
Azeirah Jan 20, 2023
96c1917
Fix: Don't include deleted pages in cPages for v3
Azeirah Jan 20, 2023
bd94728
Refactor: Remove unnecessary arg from ocr
Azeirah Jan 20, 2023
4431937
Add: Book test
Azeirah Jan 21, 2023
941bb99
Add: Partial .rm v6 support
Azeirah Jan 21, 2023
afe59a3
Hack to print all layers in v3
Azeirah Jan 21, 2023
19795c3
Improve rmscene importing
Azeirah Mar 6, 2023
89518ee
Merge branch 'upstream-master'
Azeirah Mar 6, 2023
812e320
Merge branch 'master' into v6_with_rmscene
Azeirah Mar 6, 2023
989a8e7
Merge branch 'upstream-master' into v6_with_rmscene
Azeirah Mar 12, 2023
9ff4def
Update to rmscene v3
Azeirah Mar 22, 2023
4065d4e
Add rmscene v3 as dependency
Azeirah Mar 22, 2023
ad98c1a
Batch annotations per tool for increased performance
Azeirah Mar 22, 2023
596f0e7
Merge branch 'improve_annotation_drawing_performance' into v6_with_rm…
Azeirah Mar 22, 2023
5d5daf7
Replace exponentially scaling eraser width with linearly scaling eras…
Azeirah Apr 2, 2023
fc0f215
Force eraser to always have a color_code of white
Azeirah Apr 2, 2023
cf82278
Update rmscene to 0.4.0
Azeirah Jun 13, 2023
7a5d9c3
Handle coordinates in v6 correctly
Azeirah Jun 17, 2023
f934a29
Better support for extended pages
Azeirah Jun 17, 2023
53da976
Update rmscene to 0.3.3
Azeirah Jun 20, 2023
3a60658
Improved handling of global horizontal offsets
Azeirah Jun 25, 2023
521d3f1
Handle next_items assertion error when ReMarkable document has an unr…
Azeirah Jun 25, 2023
fbd03f6
Fix missing scale variable crash for smart highlights
Azeirah Jul 9, 2023
603ca19
update remarks
Azeirah Jul 9, 2023
9e5ebdc
Add support for PDFs with inserted pages
Azeirah Jul 23, 2023
9283e2d
Fix crash pre v6
Azeirah Jul 23, 2023
8036ae1
Remove lingering comments
Azeirah Jul 23, 2023
9f3a042
Add snapshot testing and test case for inserted pages in pdf notebook
Azeirah Jul 23, 2023
0bcda70
Add glyphrange-based highlighter
Azeirah Aug 9, 2023
13eb00b
Add black
Azeirah Aug 9, 2023
6d50256
Add missing syrupy to lock file
Azeirah Aug 9, 2023
0962cec
depend on my prod release of rmscene rather than rmscene main
Azeirah Aug 12, 2023
93abf89
httpsify link
Azeirah Aug 12, 2023
dbf8c92
Refactor logic into Document class
Azeirah Aug 13, 2023
4da4e1c
refactor: Move Document to own file
Azeirah Aug 13, 2023
f9380d7
Add Obsidian md output
Azeirah Aug 13, 2023
a236f9f
remove lingering print
Azeirah Aug 13, 2023
8fde424
Cleanup code
Azeirah Aug 13, 2023
4d6be15
Refactor: Move obsidian markdown file class to own file
Azeirah Aug 13, 2023
0b4941b
Update remarks version
Azeirah Aug 13, 2023
8edc1ac
Add warning callout
Azeirah Aug 13, 2023
4b76983
Only generate obsidian markdown files if there's content in it
Azeirah Aug 13, 2023
eaac1c4
Don't show page header if no pages have highlights
Azeirah Aug 13, 2023
b3740dc
version p
Azeirah Aug 13, 2023
8b357db
Fix pyproject rmscene dependency syntax
Azeirah Aug 23, 2023
831c436
Filter highlights that are not visible on the page
Azeirah Aug 23, 2023
01171f6
update rmscene
Azeirah Aug 23, 2023
92a6064
Update lock
Azeirah Aug 23, 2023
db7b2eb
Add updated rmscene handling an unexpected subblock
Azeirah Sep 3, 2023
05a46fa
Fix typo on homepage
Azeirah Jan 31, 2024
34952c3
Fix page index issue in obsidian output
Azeirah May 26, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Refactor: Remove unnecessary arg from ocr
Azeirah committed Jan 20, 2023
commit bd94728bdaaeda56f19a537771a5c22f633e061f
4 changes: 2 additions & 2 deletions remarks/remarks.py
Original file line number Diff line number Diff line change
@@ -301,7 +301,7 @@ def process_document(
and not avoid_ocr
):
logging.warning("- Will run OCRmyPDF on this document. Hold on!")
work_doc, ann_page = process_ocr(work_doc, ann_page)
work_doc, ann_page = process_ocr(work_doc)
is_ocred = True

ann_page = draw_annotations_on_pdf(ann_data, ann_page)
@@ -441,7 +441,7 @@ def process_document(
pdf_src.close()


def process_ocr(work_doc, ann_page):
def process_ocr(work_doc):
tmp_fname = "_tmp.pdf"
work_doc.save(tmp_fname)