Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #109, Fix #107 #119

Closed
wants to merge 5 commits into from
Closed

Fix #109, Fix #107 #119

wants to merge 5 commits into from

Conversation

sisby-folk
Copy link

Basically just pulled everything from the patched version of extras to make an upgrade-safe version of seasons.

I'll be using this as a custom build for a while, but let me know if anything is out of place.

@lucaargolo
Copy link
Owner

Hey, thanks for the PR! Unfortunately, I can't just add the old blocks in this mod cause it'll make it needed on the server/client. That's why I implemented it in the extras mod. I could use the fix for #107 tho, so if you can open another PR with just that I would happily merge it.

@sisby-folk
Copy link
Author

It's a new feature of 2.0 to be able to install this mod just on the server, right? would it be possible to make one release intended for upgrading old worlds (2.0.2) and then another release with this feature immediately removed? (2.0.3)

@lucaargolo
Copy link
Owner

That's possible but it would be really confusing for a lot of players. You can always just use the custom release of Fabric Extras in the pinned issue to convert your old worlds.

@sisby-folk
Copy link
Author

All good then! We'll continue this as a fork for Tinkerer's Quilt because we specifically need backwards save compatibility, but not adding any items (at the same time). Feel free to close this PR and cherry pick the #107 fix!

@lucaargolo
Copy link
Owner

If you want, you can release it as a standalone mod (just the compat with old blocks). I'll gladly point out to people who have the same problem, and I bet it would help many players.

@lucaargolo lucaargolo closed this May 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants