Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable basic support for riscv64 #282

Merged
merged 1 commit into from
Oct 18, 2023

Conversation

Hamlin-Li
Copy link

@Hamlin-Li Hamlin-Li commented Oct 17, 2023

Hi,
Can you take a look at this patch which try to bring basic riscv64 support to zstd-jni?
This patch is based on pr #281 , and pr #280 .

Thanks!

Test

I have run the test via QEMU by following command:

CC=riscv64-linux-gnu-gcc ./sbt -java-home ~/jdk/build/linux-riscv64-server-release/images/jdk/ testOnly

There are lots of output, seems there is no error, and the bottom lines of output are:

[info] Total number of tests run: 151
[info] Suites: completed 3, aborted 0
[info] Tests: succeeded 151, failed 0, canceled 0, ignored 0, pending 0
[info] All tests passed.

@luben
Copy link
Owner

luben commented Oct 17, 2023

LGTM, I just want to verify if I have the right cross compiler toolchain.

@codecov-commenter
Copy link

codecov-commenter commented Oct 18, 2023

Codecov Report

Merging #282 (fb2faf0) into master (780994b) will increase coverage by 0.14%.
Report is 1 commits behind head on master.
The diff coverage is n/a.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@             Coverage Diff              @@
##             master     #282      +/-   ##
============================================
+ Coverage     59.60%   59.74%   +0.14%     
  Complexity      301      301              
============================================
  Files            26       26              
  Lines          1421     1421              
  Branches        164      164              
============================================
+ Hits            847      849       +2     
+ Misses          419      417       -2     
  Partials        155      155              

@luben luben merged commit a2cc976 into luben:master Oct 18, 2023
6 checks passed
@Hamlin-Li
Copy link
Author

Thanks for your review!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants