Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize vector normalize and dot IR #1504

Closed
wants to merge 3 commits into from
+8 −6
Closed

Optimize vector normalize and dot IR #1504

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
dc0ec48
Update IrTranslateBuiltins.cpp
green-real Nov 2, 2024
f5df0c2
Update IrTranslateBuiltins.cpp
green-real Nov 2, 2024
d9fd091
Merge branch 'luau-lang:master' into vector-ir-changes
green-real Nov 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 8 additions & 6 deletions CodeGen/src/IrTranslateBuiltins.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -957,13 +957,13 @@ static BuiltinImplResult translateBuiltinVectorNormalize(

IrOp mag = build.inst(IrCmd::SQRT_NUM, sum);
IrOp inv = build.inst(IrCmd::DIV_NUM, build.constDouble(1.0), mag);
IrOp invvec = build.inst(IrCmd::NUM_TO_VEC, inv);

IrOp xr = build.inst(IrCmd::MUL_NUM, x, inv);
IrOp yr = build.inst(IrCmd::MUL_NUM, y, inv);
IrOp zr = build.inst(IrCmd::MUL_NUM, z, inv);
IrOp vec = build.inst(IrCmd::LOAD_TVALUE, arg1, build.constInt(0), build.constTag(LUA_TVECTOR));
IrOp norm = build.inst(IrCmd::MUL_VEC, vec, invvec);

build.inst(IrCmd::STORE_VECTOR, build.vmReg(ra), xr, yr, zr);
build.inst(IrCmd::STORE_TAG, build.vmReg(ra), build.constTag(LUA_TVECTOR));
IrOp result = build.inst(IrCmd::TAG_VECTOR, norm);
build.inst(IrCmd::STORE_TVALUE, build.vmReg(ra), result);

return {BuiltinImplType::Full, 1};
}
Expand Down Expand Up @@ -1027,11 +1027,13 @@ static BuiltinImplResult translateBuiltinVectorDot(IrBuilder& build, int nparams
IrOp y2 = build.inst(IrCmd::LOAD_FLOAT, args, build.constInt(4));
IrOp yy = build.inst(IrCmd::MUL_NUM, y1, y2);

IrOp sum0 = build.inst(IrCmd::ADD_NUM, xx, yy);

IrOp z1 = build.inst(IrCmd::LOAD_FLOAT, arg1, build.constInt(8));
IrOp z2 = build.inst(IrCmd::LOAD_FLOAT, args, build.constInt(8));
IrOp zz = build.inst(IrCmd::MUL_NUM, z1, z2);

IrOp sum = build.inst(IrCmd::ADD_NUM, build.inst(IrCmd::ADD_NUM, xx, yy), zz);
IrOp sum = build.inst(IrCmd::ADD_NUM, sum0, zz);

build.inst(IrCmd::STORE_DOUBLE, build.vmReg(ra), sum);
build.inst(IrCmd::STORE_TAG, build.vmReg(ra), build.constTag(LUA_TNUMBER));
Expand Down
Loading