Replace json serialization with dart_json_mapper and upgrade to Dart 2.0. #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Upgrade to Dart 2.0. Replace log4dart with logger.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wanted to use harvest on my project, so I had to upgrade it to Dart 2 compatibility.
I replaced all the conflicting libraries with different ones and since I am going to use it in flutter I also ripped out Polymer.
In the process I made at least one major breaking change - which is to use
dart_json_mapperfor serialization, which is going to impose itself onto users. That is fine for my project at least at this stage.Tests are passing.
Let me know if you want to pursue this PR and what else would need to be done to have it to your standards or if I should just treat it like a fork.