-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Detail the column addition process. #57
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just had a few questions, but nothing to really fix. Love the added detail!
See the :ref:`add-columns-structure` section below. | ||
|
||
- Identify the source of the data. | ||
ConsDB does not produce any data itself, nor does the ConsDB team request that sources produce data. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm trying to understand this second phrase, does that mean we don't go ask EFD to start producing an entry we want?
- Provide information about the requested columns including a brief description in the appropriate Confluence page: `Transformed EFD <https://rubinobs.atlassian.net/wiki/x/Ii7pAg>`__ or `Non-EFD <https://rubinobs.atlassian.net/wiki/x/GICzDg>`__. | ||
This provides an opportunity for discussion and comment on the suitability of the columns. | ||
|
||
- For non-EFD columns, file a Jira ticket and start a corresponding pull request to modify the `sdm_schemas <https://github.com/lsst/sdm_schemas>`__ repository with appropriate entries for the desired columns. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add 'Link that ticket in the confluence page above'
This data will go into a ``*_efd`` table. | ||
|
||
- A system (e.g. the Camera Control System), service (e.g. Rapid Analysis), or campaign/pipeline (e.g. Nightly Validation) executing at the Summit or USDF. | ||
This data will go into a table with a suffix specific to the source. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just for my own clarification, RA -> _quicklook, so the suffix is specific, but doesn't have to match the service name. Are there any other suffix specific service/pipeline/system ones yet?
No description provided.