Migrations for recent sdm_schemas: psf, pixelscale, mountjitter, magnitude limits #52
Conversation
alembic/latiss/versions/bf7ba4e029d4_add_exposure_quicklook_to_latiss_and_.py
Outdated
Show resolved
Hide resolved
| schema="cdb_latiss", | ||
| ) | ||
| op.add_column( | ||
| "exposure", |
There was a problem hiding this comment.
Do we know that these are being added to the Header Service? Where's the ticket for adding these to hinfo? If the source is not Header Service/hinfo, these should not be in the exposure table. (And we should have caught this earlier in the review of the sdm_schemas PR.)
There was a problem hiding this comment.
We talked and agreed there was no plan for these; expect them removed in the next push.
Should we also remove from sdm_schemas so they do not get continually readded?
There was a problem hiding this comment.
We talked and agreed there was no plan for these; expect them removed in the next push.
Should we also remove from sdm_schemas so they do not get continually readded?
Removal of columns should be managed through sdm_schemas PRs, and then these changes will be used to generate the migrations.
There was a problem hiding this comment.
We didn't update this comment thoroughly, we did adjust through sdm_schemas PR here: lsst/sdm_schemas#284
| ), | ||
| schema="cdb_latiss", | ||
| ) | ||
| op.drop_column("visit1_quicklook", "postisr_pixel_median", schema="cdb_latiss") |
There was a problem hiding this comment.
I think we decided that this column hadn't been used so this isn't a backwards-compatibility issue, correct?
There was a problem hiding this comment.
Is there data in this table yet? It doesn't seem so from my cursory queries; so there would be no incompatibility then.
There was a problem hiding this comment.
And in lsstcomcam, there are only 'postisr_pixel_median_median', and mean, and max.
For latiss, this value is in exposure_quicklook, so I think I agree this is a duplicate of info as well.
|
@Vebop Does this get the consdb migration scripts completely up to date with the current I just wanted to verify (ticket description seems to indicate that this should cover all outstanding migrations), because we shouldn't turn on the automatic migrations added by DM-47507 until we are completely caught up. |
Vebop
force-pushed
the
tickets/DM-47443
branch
2 times, most recently
from
53a5f74
to
e0380e3
Compare
|
@JeremyMcCormick Yes I believe this does account for all updates that have been included in sdm_schemas up to this point. I will make sure you know when these have been applied to the summit and USDF so we can set the automatic process to play. |
Vebop
force-pushed
the
tickets/DM-47443
branch
from
e0380e3
to
db81f21
Compare
|
Thanks for the approve! Rebased, then will merge after the checks complete. |
Added migrations for minor changes in latiss, lsstcomcam,sim and added startracker tables:
add exposure quicklook to latiss and updates including pixelscale psf mount jitter and magnitude limits