Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove audit feature (#107) #288

Merged
merged 2 commits into from
Jun 27, 2024
Merged

Conversation

davidcoutadeur
Copy link
Contributor

Closes #107

@davidcoutadeur davidcoutadeur added this to the 2.2 milestone May 17, 2024
@davidcoutadeur davidcoutadeur self-assigned this May 17, 2024
Copy link
Contributor

@rouazana rouazana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this cleanup!

I still see some Audit references:

  • lsc.episode
  • src/main/java/org/lsc/configuration/.gitignore (do we really need this file?)

Can you check please?

@davidcoutadeur
Copy link
Contributor Author

Thank you for this cleanup!

I still see some Audit references:

* lsc.episode

* src/main/java/org/lsc/configuration/.gitignore (do we really need this file?)

Can you check please?

Ok, I'll give a look to this before merging.

@davidcoutadeur davidcoutadeur force-pushed the 107-remove-audit-feature branch from 81d1491 to 1c82a3d Compare June 27, 2024 16:11
@davidcoutadeur
Copy link
Contributor Author

Thank you for this cleanup!

I still see some Audit references:

* lsc.episode

* src/main/java/org/lsc/configuration/.gitignore (do we really need this file?)

Can you check please?

Both fixed in commit 28023cb

.gitignore seems really useful, since all files in configuration/ are generated at each compilation, except 3 of them. I have simplified the .gitignore to reflect this behavior, and take future files to ignore into account.

@davidcoutadeur davidcoutadeur merged commit 8ce90e1 into master Jun 27, 2024
1 check passed
@davidcoutadeur davidcoutadeur deleted the 107-remove-audit-feature branch June 27, 2024 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove audit feature
2 participants