RPM specfile cleanup #246
Merged
RPM specfile cleanup #246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Closed
xavierba
force-pushed
the
specfile_cleanup
branch
from
4df8061 to
3d18353
Compare
src/install/lsc-core.spec
Outdated
| %dir %{_sysconfdir}/lsc/sql-map-config.d/ | ||
| %config(noreplace) %{_sysconfdir}/lsc/sql-map-config.d/InetOrgPerson.xml | ||
| %config(noreplace) %{_sysconfdir}/cron.d/lsc | ||
| %config(noreplace) %{_sysconfdir}/default/lsc |
There was a problem hiding this comment.
I think some lines have been dropped during the rebase.
Here we should:
- remove: (this file does not exist anymore)
%config(noreplace) %{_sysconfdir}/default/lsc
- add:
%config(noreplace) %{_sysconfdir}/default/lsc-sync
%config(noreplace) %{_sysconfdir}/default/lsc-async
All other modification seems, ok. Thanks for you hard work!
There was a problem hiding this comment.
good catch, fixed.
xavierba
force-pushed
the
specfile_cleanup
branch
from
3d18353 to
fafea4a
Compare
Closed
xavierba
force-pushed
the
specfile_cleanup
branch
from
fafea4a to
2eac030
Compare
- Add a comment - Suppress shell - Change home directory to /var/lib/lsc
xavierba
force-pushed
the
specfile_cleanup
branch
4 times, most recently
from
265f0f3 to
7cf6d49
Compare
xavierba
force-pushed
the
specfile_cleanup
branch
from
7cf6d49 to
d94b38c
Compare
xavierba
force-pushed
the
specfile_cleanup
branch
from
d94b38c to
afb4ed2
Compare
xavierba
force-pushed
the
specfile_cleanup
branch
from
da97f8b to
3def7ef
Compare
Closed
|
I have done a complete review and testing of this issue. For me, it can merged. |
Feel free to merge it, it's ok for me too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extensive RPM specfile cleanup.
Closes #265