Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add a create/update/changeId/delete posthook (#193) #242

Merged
merged 5 commits into from
Dec 11, 2023
Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -872,6 +872,21 @@
<artifactId>xml-apis</artifactId>
<version>1.4.01</version>
</dependency>
<dependency>
<groupId>com.fasterxml.jackson.core</groupId>
<artifactId>jackson-core</artifactId>
<version>2.9.6</version>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you put the common version in a property?
(by the way do you really need these 3 dependencies?)

</dependency>
<dependency>
<groupId>com.fasterxml.jackson.core</groupId>
<artifactId>jackson-annotations</artifactId>
<version>2.9.6</version>
</dependency>
<dependency>
<groupId>com.fasterxml.jackson.core</groupId>
<artifactId>jackson-databind</artifactId>
<version>2.9.6</version>
</dependency>
</dependencies>

<distributionManagement>
Expand Down
189 changes: 189 additions & 0 deletions src/main/java/org/lsc/Hooks.java
Original file line number Diff line number Diff line change
@@ -0,0 +1,189 @@
/*
****************************************************************************
* Ldap Synchronization Connector provides tools to synchronize
* electronic identities from a list of data sources including
* any database with a JDBC connector, another LDAP directory,
* flat files...
*
* ==LICENSE NOTICE==
*
* Copyright (c) 2008 - 2011 LSC Project
* All rights reserved.
*
* Redistribution and use in source and binary forms, with or without
* modification, are permitted provided that the following conditions are met:

*    * Redistributions of source code must retain the above copyright
* notice, this list of conditions and the following disclaimer.
*     * Redistributions in binary form must reproduce the above copyright
* notice, this list of conditions and the following disclaimer in the
* documentation and/or other materials provided with the distribution.
*     * Neither the name of the LSC Project nor the names of its
* contributors may be used to endorse or promote products derived from
* this software without specific prior written permission.
*
* THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS
* IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED
* TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A
* PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT OWNER
* OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL,
* EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO,
* PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR
* PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF
* LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING
* NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS
* SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
*
* ==LICENSE NOTICE==
*
* (c) 2008 - 2011 LSC Project
****************************************************************************
*/
package org.lsc;

import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
import java.lang.ProcessBuilder;
import java.io.OutputStream;
import java.io.IOException;
import java.io.StringWriter;
import java.io.PrintWriter;
import org.lsc.utils.output.LdifLayout;
import com.fasterxml.jackson.databind.ObjectMapper; // For encoding object to JSON
import com.fasterxml.jackson.databind.ObjectWriter;


/**
* This object is managing posthook scripts
*/
public class Hooks {

static final Logger LOGGER = LoggerFactory.getLogger(AbstractSynchronize.class);
/**
* Method calling a postSyncHook if necessary
*
* return nothing
*/
public final static void postSyncHook(final String hook, final String outputFormat, final LscModifications lm) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

style: in general in Java we don't use static methods. You can construct the object in the constructor of the caller.


if( hook != null && ! hook.equals("") )
{

String format = "";
if( outputFormat.equals("json") ) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the parsing of the outputFormat should be done previously, here you should be able to manipulate only an Enum

format = "json";
}
else
{
format = "ldif";
}

// Compute json/ldif modifications
String modifications = null;

switch (lm.getOperation()) {
case CREATE_OBJECT:
if( format.equals("json") ) {
modifications = getJsonModifications(lm);
}
else {
modifications = LdifLayout.format(lm);
}
callHook("create", hook, lm.getMainIdentifier(), format, modifications);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these lines can be easily factorized, and in this case easily integrated in the callHook method

break;

case UPDATE_OBJECT:
if( format.equals("json") ) {
modifications = getJsonModifications(lm);
}
else {
modifications = LdifLayout.format(lm);
}
callHook("update", hook, lm.getMainIdentifier(), format, modifications);
break;

case CHANGE_ID:
if( format.equals("json") ) {
modifications = getJsonModifications(lm);
}
else {
modifications = LdifLayout.format(lm);
}
callHook("changeId", hook, lm.getMainIdentifier(), format, modifications);
break;

case DELETE_OBJECT:
callHook("delete", hook, lm.getMainIdentifier(), format, modifications);
break;

default:
LOGGER.info("Error: unknown operation for posthook {}", hook);
}
}
}

/**
* Method calling the hook
*
* return nothing
*/
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure such comments are really useful

public final static void callHook( String operationType,
String hook,
String identifier,
String format,
String modifications) {

LOGGER.info("Calling {} posthook {} with format {} for {}", operationType, hook, format, identifier);
try {
if( modifications != null ) {
Process p = new ProcessBuilder(
hook,
identifier,
operationType)
.start();

// sends ldif modifications to stdin of hook script
OutputStream stdin = p.getOutputStream();
stdin.write(modifications.getBytes());
stdin.write("\n".getBytes());
stdin.flush();
stdin.close();
}
else {
Process p = new ProcessBuilder(
hook,
identifier,
operationType)
.start();
}
}
catch(IOException e) {
StringWriter sw = new StringWriter();
PrintWriter pw = new PrintWriter(sw);
e.printStackTrace(pw);
LOGGER.error("Error while calling {} posthook {} with format {} for {}: {}",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do you know that the LOGGER.error can directly take an exception as a parameter, and so log the stack trace without all this stuff?

operationType, hook, format, identifier, sw.toString());
}
}

/**
* Method computing modifications as json
*
* @return modifications in a json String
*/
public final static String getJsonModifications(final LscModifications lm) {
ObjectWriter ow = new ObjectMapper().writer().withDefaultPrettyPrinter();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nits (perf): it's recommended to declare your ObjectMapper as static for performace reasons.

String json = "";
try {
json = ow.writeValueAsString(lm.getLscAttributeModifications());
}
catch(Exception e) {
StringWriter sw = new StringWriter();
PrintWriter pw = new PrintWriter(sw);
e.printStackTrace(pw);
LOGGER.error("Error while encoding LSC modifications to json", sw.toString());
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same remark about stack trace logging

}
return json;
}

}
24 changes: 24 additions & 0 deletions src/main/java/org/lsc/beans/syncoptions/ForceSyncOptions.java
Original file line number Diff line number Diff line change
Expand Up @@ -128,6 +128,30 @@ public String getCondition(LscModificationType operation) {
return DEFAULT_CONDITION;
}

public String getPostHookOutputFormat() {
return "";
}

public String getCreatePostHook() {
return "";
}

public String getDeletePostHook() {
return "";
}

public String getUpdatePostHook() {
return "";
}

public String getChangeIdPostHook() {
return "";
}

public String getPostHook(LscModificationType operation) {
return "";
}

public String getDn() {
return null;//((Ldap)task.getDestinationService()).getDn();
}
Expand Down
38 changes: 38 additions & 0 deletions src/main/java/org/lsc/beans/syncoptions/ISyncOptions.java
Original file line number Diff line number Diff line change
Expand Up @@ -153,6 +153,44 @@ public interface ISyncOptions {

String getCondition(LscModificationType operation);

/**
* Returns the posthook output format
*
* @return the posthook output format or "" if none is specified (default)
*/
String getPostHookOutputFormat();

/**
* Returns the posthook for a creation
*
* @return the posthook or "" if none is specified (default)
*/
String getCreatePostHook();

/**
* Returns the posthook for an update
*
* @return the posthook or "" if none is specified (default)
*/
String getUpdatePostHook();

/**
* Returns the posthook for a delete
*
* @return the posthook or "" if none is specified (default)
*/
String getDeletePostHook();

/**
* Returns the posthook for a id change
*
* @return the posthook or "" if none is specified (default)
*/
String getChangeIdPostHook();


String getPostHook(LscModificationType operation);

/**
* Return the expression used to infer the new object DN
* @return the new object dn pattern
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -196,6 +196,60 @@ public String getCondition(LscModificationType operation) {
}
return result;
}

public String getPostHookOutputFormat() {
if (conf.getHooks() == null || conf.getHooks().getOutputFormat() == null) {
return "";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As said earlier, the result of this method should be an enum.
Also, I would make clearer here which is the default value.

}
return conf.getHooks().getOutputFormat();
}

public String getCreatePostHook() {
if (conf.getHooks() == null || conf.getHooks().getCreatePostHook() == null) {
return "";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

style: I usually prefer returning an Optional to indicate there is a value or not.

But here I did not check what are the consequences, it can be a little more complicated to handle if you are not used to.

}
return conf.getHooks().getCreatePostHook();
}

public String getDeletePostHook() {
if (conf.getHooks() == null || conf.getHooks().getDeletePostHook() == null) {
return "";
}
return conf.getHooks().getDeletePostHook();
}

public String getUpdatePostHook() {
if (conf.getHooks() == null || conf.getHooks().getUpdatePostHook() == null) {
return "";
}
return conf.getHooks().getUpdatePostHook();
}

public String getChangeIdPostHook() {
if (conf.getHooks() == null || conf.getHooks().getChangeIdPostHook() == null) {
return "";
}
return conf.getHooks().getChangeIdPostHook();
}

public String getPostHook(LscModificationType operation) {
String result = "";
switch (operation) {
case CREATE_OBJECT:
result = this.getCreatePostHook();
break;
case UPDATE_OBJECT:
result = this.getUpdatePostHook();
break;
case DELETE_OBJECT:
result = this.getDeletePostHook();
break;
case CHANGE_ID:
result = this.getChangeIdPostHook();
break;
}
return result;
}

public String getDelimiter(String name) {
DatasetType dataset = LscConfiguration.getDataset(conf, name);
Expand Down
1 change: 1 addition & 0 deletions src/main/java/org/lsc/configuration/.gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
/AuditType.java
/AuditsType.java
/ConditionsType.java
/HooksType.java
/ConnectionType.java
/ConnectionsType.java
/CsvAuditType.java
Expand Down
5 changes: 5 additions & 0 deletions src/main/java/org/lsc/runnable/CleanEntryRunner.java
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@
import org.lsc.utils.ScriptingEvaluator;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
import org.lsc.Hooks;

/**
* @author sfroger
Expand Down Expand Up @@ -108,6 +109,10 @@ public void run() {
// if we got here, we have a modification to apply - let's
// do it!
if (task.getDestinationService().apply(lm)) {
// Retrieve posthook for the current operation
String hook = syncOptions.getDeletePostHook();
String outputFormat = syncOptions.getPostHookOutputFormat();
Hooks.postSyncHook(hook, outputFormat, lm);
counter.incrementCountCompleted();
abstractSynchronize.logAction(lm, id, task.getName());
} else {
Expand Down
Loading
Loading