Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add github action #238

Merged
merged 5 commits into from
Oct 19, 2023
Merged

Add github action #238

merged 5 commits into from
Oct 19, 2023

Conversation

coudot
Copy link
Member

@coudot coudot commented Oct 18, 2023

See #237

@coudot coudot linked an issue Oct 18, 2023 that may be closed by this pull request
@coudot coudot mentioned this pull request Oct 18, 2023
@coudot coudot requested a review from rouazana October 18, 2023 21:04
@coudot coudot added this to the 2.2 milestone Oct 18, 2023
@rouazana
Copy link
Contributor

Great, it works!

Could you also add the build with Java 11 as we previously had with Travis?

@coudot
Copy link
Member Author

coudot commented Oct 19, 2023

I added another steps with JDK 11 but test with JDK 8 are failing with:

Warning:       [echo] Starting OpenDJ embedded server from /home/runner/work/lsc/lsc/target/test-classes
[INFO]      [java] Unrecognized option: --add-exports=java.base/sun.security.tools.keytool=ALL-UNNAMED
[INFO]      [java] Error: Could not create the Java Virtual Machine.
[INFO]      [java] Error: A fatal exception has occurred. Program will exit.
Error:       [java] Java Result: 1
Error: The operation was canceled.

Not sure it is linked to my modification. What do you think?

@coudot
Copy link
Member Author

coudot commented Oct 19, 2023

Same error after reverting the latest commit, should be linked to 2d47fa3

Trying to run JDK 11 test before JDK 8 test to confirm this.

@coudot
Copy link
Member Author

coudot commented Oct 19, 2023

Seems we could use if/else in ant: https://ant.apache.org/manual/ifunless.html

@rouazana is this something you can look at?

@rouazana
Copy link
Contributor

Strange, I tested the build with Java 8 without any issue.

I will have a look.

@rouazana
Copy link
Contributor

It should be fixed, I will rebase your PR to check.

@rouazana rouazana merged commit 2e62f46 into master Oct 19, 2023
1 check passed
@rouazana rouazana deleted the github-action-mvn branch October 19, 2023 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Automatic build is broken
2 participants