Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notifications: Add new iOS notification api #11

Merged
merged 1 commit into from
Nov 28, 2024

Conversation

PaRangger
Copy link
Contributor

Motivation

Currently, the notifications in iOS are running as background notifications. To change this, we need to send different payloads to iOS18 devices, while keeping the iOS17 and lower devices the same.

Description

The artemis server will now send a api version of the device. To react to this I have changed the apns service to read this new value and update the payload accordingly (content type = false, mutable content = true, a default alert body, and PushType.ALERT).

@PaRangger PaRangger self-assigned this Nov 15, 2024
@PaRangger PaRangger changed the title Development: Add new iOS notification api Notifications: Add new iOS notification api Nov 15, 2024
@PaRangger PaRangger marked this pull request as ready for review November 25, 2024 11:11
Copy link
Member

@anian03 anian03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes tested locally, payload on default version and iOS_V2 both look as expected

@PaRangger PaRangger merged commit b33a4a1 into main Nov 28, 2024
2 checks passed
@PaRangger PaRangger deleted the feature/development/add-new-ios-api-to-service branch November 28, 2024 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants