-
Notifications
You must be signed in to change notification settings - Fork 300
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Development
: Use default value if exercise has no plagiarism checks config
#7665
Development
: Use default value if exercise has no plagiarism checks config
#7665
Conversation
…h-no-plagiarism-detection-config
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code LGTM
Thanks for fixing this, but I already implemented #7657 with the same fix. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried to test this PR on TS2, Legcay_TS1, Legacy_TS2 and Legacy_TS11, and I always only saw the loading screen ("We'll be back soon"). I don't know what problems Artemis has right now but I had the same issue with other PRs too.
I will try to test this PR again tomorrow.
…h-no-plagiarism-detection-config
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested on ts2. Worked as expected
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Manual tested on ts2. Worked as expected.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code lgtm, let's merge that quickly.
…h-no-plagiarism-detection-config
Checklist
General
Client
Motivation and Context
Importing programming exercises from files created before merging of the continuous plagiarism control was not possible, because such files didn't contain plagiarism checks config. This caused the client to load the exercise creation form incorrectly.
Detected during tests of: #7624
Server part fixed in: #7640
Description
This PR adds a nullability check for exercise's plagiarism detection config before the exercise form is initialised. If exercise does not contain plagiarism detection config, the component inserts a default value into it.
Steps for Testing
Prerequisites:
Testserver States
Note
These badges show the state of the test servers.
Green = Currently available, Red = Currently locked
Review Progress
Performance Review
Code Review
Manual Tests
Test Coverage