Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Announcements emails are send twice to tutors/editors #5348

Closed
fh314 opened this issue Jul 8, 2022 · 6 comments
Closed

Announcements emails are send twice to tutors/editors #5348

fh314 opened this issue Jul 8, 2022 · 6 comments

Comments

@fh314
Copy link
Contributor

fh314 commented Jul 8, 2022

Describe the bug

As an editor of the EIST courses, I always receive the announcements emails twice.

To Reproduce

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See error

Expected behavior

Only send announcement emails once to editors/tutors

Screenshots

No response

What browsers are you seeing the problem on?

Chrome

Additional context

No response

Relevant log output

No response

@krusche
Copy link
Member

krusche commented Jul 8, 2022

I think this happens because we have two courses with similar announcements, one for Garching and one for Heilbronn.
Did you double check that you received the exact same email with the same course name?

@krusche krusche closed this as completed Jul 8, 2022
@fh314
Copy link
Contributor Author

fh314 commented Jul 12, 2022

Yes, I did get two emails for Heilbronn and Garching each
image

@fh314 fh314 reopened this Jul 12, 2022
@krusche
Copy link
Member

krusche commented Jul 13, 2022

Are you maybe listed twice in the course? For example as tutor and as editor?

@fh314
Copy link
Contributor Author

fh314 commented Jul 13, 2022

Apparently that seems to be the problem. I don't know if fixing this behavior is of any priority so feel free to close

@krusche
Copy link
Member

krusche commented Jul 13, 2022

We should definitely fix it and take a set-based union of all students, tutors, editors and instructors of the course before sending the emails to avoid potential duplicates. Should be relatively easy to implement if someone finds the corresponding source code

@ge65cer
Copy link
Contributor

ge65cer commented Oct 18, 2022

Duplicate of #5246

@ge65cer ge65cer marked this as a duplicate of #5246 Oct 18, 2022
@ge65cer ge65cer closed this as not planned Won't fix, can't repro, duplicate, stale Oct 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants