Plagiarsim checks: Fix default value of after due date checks (#7657)

ls1intum · Dec 8, 2023 · c227a8d · c227a8d
1 parent b9df09c
commit c227a8d
Show file tree

Hide file tree

Showing 4 changed files with 67 additions and 12 deletions.
diff --git a/src/main/webapp/app/entities/exercise.model.ts b/src/main/webapp/app/entities/exercise.model.ts
@@ -54,9 +54,9 @@ export interface PlagiarismDetectionConfig {
     minimumSize?: number;
 }
 
-export const defaultPlagiarismDetectionConfig: PlagiarismDetectionConfig = {
+export const DEFAULT_PLAGIARISM_DETECTION_CONFIG: PlagiarismDetectionConfig = {
     continuousPlagiarismControlEnabled: false,
-    continuousPlagiarismControlPostDueDateChecksEnabled: true,
+    continuousPlagiarismControlPostDueDateChecksEnabled: false,
     similarityThreshold: 90,
     minimumSize: 50,
     minimumScore: 0,
@@ -105,7 +105,7 @@ export abstract class Exercise implements BaseEntity {
     public exerciseGroup?: ExerciseGroup;
     public competencies?: Competency[];
 
-    public plagiarismDetectionConfig?: PlagiarismDetectionConfig = defaultPlagiarismDetectionConfig;
+    public plagiarismDetectionConfig?: PlagiarismDetectionConfig = DEFAULT_PLAGIARISM_DETECTION_CONFIG; // default value
 
     // transient objects which might not be set
     public numberOfSubmissions?: DueDateStat;

diff --git a/...es/shared/plagiarism/exercise-update-plagiarism/exercise-update-plagiarism.component.html b/...es/shared/plagiarism/exercise-update-plagiarism/exercise-update-plagiarism.component.html
@@ -12,8 +12,8 @@
                     id="continuous_plagiarism_control_enabled"
                     class="plagiarism-option-checkbox form-check-input"
                     name="exercise.plagiarismDetectionConfig.continuousPlagiarismControlEnabled"
-                    #exercise.plagiarismDetectionConfig.continuousPlagiarismControlEnabled="ngModel"
-                    [(ngModel)]="exercise.plagiarismDetectionConfig!.continuousPlagiarismControlEnabled"
+                    [checked]="exercise.plagiarismDetectionConfig!.continuousPlagiarismControlEnabled"
+                    (click)="toggleCPCEnabled()"
                 />
                 <div class="plagiarism-option-label" jhiTranslate="artemisApp.plagiarism.continuousPlagiarismControlEnabled">Enable Continuous Plagiarism Control</div>
             </div>
@@ -78,7 +78,7 @@
                 <div class="form-group">
                     <div>
                         <label class="form-control-label" jhiTranslate="artemisApp.plagiarism.minimumSize">Minimum Size</label>
-                        <fa-icon [icon]="faQuestionCircle" placement="bottom auto" [ngbTooltip]="getMinimumSizeTooltip() | artemisTranslate"></fa-icon>
+                        <fa-icon [icon]="faQuestionCircle" placement="bottom auto" [ngbTooltip]="minimumSizeTooltip | artemisTranslate"></fa-icon>
                     </div>
                     <input
                         type="number"

diff --git a/...ises/shared/plagiarism/exercise-update-plagiarism/exercise-update-plagiarism.component.ts b/...ises/shared/plagiarism/exercise-update-plagiarism/exercise-update-plagiarism.component.ts
@@ -1,5 +1,5 @@
 import { Component, Input, OnInit } from '@angular/core';
-import { Exercise, ExerciseType, defaultPlagiarismDetectionConfig } from 'app/entities/exercise.model';
+import { DEFAULT_PLAGIARISM_DETECTION_CONFIG, Exercise, ExerciseType } from 'app/entities/exercise.model';
 import { faQuestionCircle } from '@fortawesome/free-solid-svg-icons';
 
 @Component({
@@ -8,19 +8,29 @@ import { faQuestionCircle } from '@fortawesome/free-solid-svg-icons';
 })
 export class ExerciseUpdatePlagiarismComponent implements OnInit {
     @Input() exercise: Exercise;
+    minimumSizeTooltip?: string;
 
-    faQuestionCircle = faQuestionCircle;
+    readonly faQuestionCircle = faQuestionCircle;
 
     ngOnInit(): void {
+        this.minimumSizeTooltip = this.getMinimumSizeTooltip();
         if (!this.exercise.plagiarismDetectionConfig) {
-            this.exercise.plagiarismDetectionConfig = defaultPlagiarismDetectionConfig;
+            // Create the default plagiarism configuration if there is none (e.g. importing an old exercise from a file)
+            this.exercise.plagiarismDetectionConfig = DEFAULT_PLAGIARISM_DETECTION_CONFIG;
         }
     }
 
+    toggleCPCEnabled() {
+        const config = this.exercise.plagiarismDetectionConfig!;
+        const newValue = !config.continuousPlagiarismControlEnabled;
+        config.continuousPlagiarismControlEnabled = newValue;
+        config.continuousPlagiarismControlPostDueDateChecksEnabled = newValue;
+    }
+
     /**
      * Return the translation identifier of the minimum size tooltip for the current exercise type.
      */
-    getMinimumSizeTooltip() {
+    getMinimumSizeTooltip(): string | undefined {
         switch (this.exercise.type) {
             case ExerciseType.PROGRAMMING: {
                 return 'artemisApp.plagiarism.minimumSizeTooltipProgrammingExercise';

diff --git a/src/test/javascript/spec/component/plagiarism/exercise-update-plagiarism.component.spec.ts b/src/test/javascript/spec/component/plagiarism/exercise-update-plagiarism.component.spec.ts
@@ -1,4 +1,4 @@
-import { defaultPlagiarismDetectionConfig } from 'app/entities/exercise.model';
+import { DEFAULT_PLAGIARISM_DETECTION_CONFIG, Exercise, ExerciseType } from 'app/entities/exercise.model';
 import { ExerciseUpdatePlagiarismComponent } from 'app/exercises/shared/plagiarism/exercise-update-plagiarism/exercise-update-plagiarism.component';
 import { ProgrammingExercise } from 'app/entities/programming-exercise.model';
 
@@ -31,6 +31,51 @@ describe('Exercise Update Plagiarism Component', () => {
 
         comp.ngOnInit();
 
-        expect(comp.exercise.plagiarismDetectionConfig).toEqual(defaultPlagiarismDetectionConfig);
+        expect(comp.exercise.plagiarismDetectionConfig).toEqual(DEFAULT_PLAGIARISM_DETECTION_CONFIG);
+    });
+
+    it('should set minimumSizeTooltip on init', () => {
+        comp.exercise = { type: ExerciseType.PROGRAMMING } as Exercise;
+        comp.ngOnInit();
+        expect(comp.minimumSizeTooltip).toBe('artemisApp.plagiarism.minimumSizeTooltipProgrammingExercise');
+    });
+
+    it('should set default plagiarism detection config on init if not set', () => {
+        comp.exercise = { type: ExerciseType.PROGRAMMING } as Exercise;
+        comp.ngOnInit();
+        expect(comp.exercise.plagiarismDetectionConfig).toEqual(DEFAULT_PLAGIARISM_DETECTION_CONFIG);
+    });
+
+    it('should enable cpc', () => {
+        comp.exercise = {
+            plagiarismDetectionConfig: { continuousPlagiarismControlEnabled: false, continuousPlagiarismControlPostDueDateChecksEnabled: false },
+        } as Exercise;
+        comp.toggleCPCEnabled();
+        expect(comp.exercise.plagiarismDetectionConfig!.continuousPlagiarismControlEnabled).toBeTrue();
+        expect(comp.exercise.plagiarismDetectionConfig!.continuousPlagiarismControlPostDueDateChecksEnabled).toBeTrue();
+    });
+
+    it('should disable cpc', () => {
+        comp.exercise = {
+            plagiarismDetectionConfig: { continuousPlagiarismControlEnabled: true, continuousPlagiarismControlPostDueDateChecksEnabled: true },
+        } as Exercise;
+        comp.toggleCPCEnabled();
+        expect(comp.exercise.plagiarismDetectionConfig!.continuousPlagiarismControlEnabled).toBeFalse();
+        expect(comp.exercise.plagiarismDetectionConfig!.continuousPlagiarismControlPostDueDateChecksEnabled).toBeFalse();
+    });
+
+    it('should get correct minimumSizeTooltip for programming exercises', () => {
+        comp.exercise = { type: ExerciseType.PROGRAMMING } as Exercise;
+        expect(comp.getMinimumSizeTooltip()).toBe('artemisApp.plagiarism.minimumSizeTooltipProgrammingExercise');
+    });
+
+    it('should get correct minimumSizeTooltip for text exercises', () => {
+        comp.exercise = { type: ExerciseType.TEXT } as Exercise;
+        expect(comp.getMinimumSizeTooltip()).toBe('artemisApp.plagiarism.minimumSizeTooltipTextExercise');
+    });
+
+    it('should get correct minimumSizeTooltip for modeling exercises', () => {
+        comp.exercise = { type: ExerciseType.MODELING } as Exercise;
+        expect(comp.getMinimumSizeTooltip()).toBe('artemisApp.plagiarism.minimumSizeTooltipModelingExercise');
     });
 });