Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert to docker #1
Convert to docker #1
Changes from 6 commits
599bdb3
7b2eb15
2f2111b
b2d4eb5
f49cd5f
a9e2892
26d24fb
f6bbf95
83f3230
4e6222a
9862bc7
46708e8
718b5aa
59e47a7
29e9892
a9d3747
f23be2c
61bd5c0
f346468
9cdc91e
e884fb8
d162070
0dbce96
8046dd3
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Large diffs are not rendered by default.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@212223 why this directory move from
app
toapp/default
here and in lots of places? 🤔There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is good to have a web application served by
nginx
from a sub-directoryapp/default
instead of a parent directoryapp
because this allows to switch between applications instantaneously.For example instead of having your application inside the
app/default
dir you may have it inapp/bar
dir and a symlinkapp/default -> app/bar
that points to the dir of the application you want to serve. Demo commit.Then if you want to change the application you serve you don't need to reconfigure nginx nor restarting any of the services is required but only changing the symlink target, for example:
like in the Demo commit
and you are ready to serve the new application.
Example use cases:
Currently the web app is in the
app/default
dir. Would you like me to:default
that points to that dirapp
dir fromapp/default
and reconfigure docker-compose?