Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[New Generator] PowerGenerator from any other generator #84

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

lrnv
Copy link
Owner

@lrnv lrnv commented Nov 22, 2023

This new generator shandles outer/inner power families of archimedean generators.

A few tests and inclusion in the general documentaiton is still missing.

Copy link

codecov bot commented Nov 22, 2023

Codecov Report

Attention: 10 lines in your changes are missing coverage. Please review.

Comparison is base (49dc233) 80.70% compared to head (2fc0191) 79.53%.
Report is 1 commits behind head on main.

❗ Current head 2fc0191 differs from pull request most recent head e4980f3. Consider uploading reports for the commit e4980f3 to get more accurate results

Files Patch % Lines
src/Generator/DistordedGenerator/PowerGenerator.jl 0.00% 10 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #84      +/-   ##
==========================================
- Coverage   80.70%   79.53%   -1.18%     
==========================================
  Files          28       29       +1     
  Lines         679      689      +10     
==========================================
  Hits          548      548              
- Misses        131      141      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lrnv lrnv force-pushed the add_new_generator branch from f7edd6c to 5570e95 Compare November 23, 2023 16:39
Copy link
Owner Author

@lrnv lrnv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lacks tests

@lrnv lrnv changed the title Add PowerGenerator [New Generator] PowerGenerator from any other generator Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant