Skip to content

Commit

Permalink
Switch default for HDF5_GENERATE_HEADERS (CMake) to OFF.
Browse files Browse the repository at this point in the history
  • Loading branch information
lrknox committed Oct 24, 2024
1 parent 01957b6 commit 2ac89b3
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 3 deletions.
2 changes: 1 addition & 1 deletion release_docs/INSTALL_CMake.txt
Original file line number Diff line number Diff line change
Expand Up @@ -874,7 +874,7 @@ HDF5_ENABLE_PREADWRITE "Use pread/pwrite in sec2/log/core VFDs in place
HDF5_ENABLE_TRACE "Enable API tracing capability" OFF
HDF5_ENABLE_USING_MEMCHECKER "Indicate that a memory checker is used" OFF
HDF5_ENABLE_MAP_API "Build the map API" OFF
HDF5_GENERATE_HEADERS "Rebuild Generated Files" ON
HDF5_GENERATE_HEADERS "Rebuild Generated Files" OFF
HDF5_BUILD_GENERATORS "Build Test Generators" OFF

HDF5_JAVA_PACK_JRE "Package a JRE installer directory" OFF
Expand Down
5 changes: 4 additions & 1 deletion release_docs/RELEASE_PROCESS.md
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,9 @@ For more information on the HDF5 versioning and backward and forward compatibili
- `$ bin/h5vers -s X.Y.Z-{SR+1};`
- `$ git commit -m "Updated release preparation branch version number to X.Y.Z-{SR+1}"`
- `$ git push`
7. Update default configuration mode
7. ** OBSOLETE CURRENTLY **
Most will disappear when autotools support is removed, and none of these are currently necessary
Update default configuration mode
- `$ git checkout hdf5_X_Y_Z;` and `$ bin/switch_maint_mode -disable ./configure.ac` to disable `AM_MAINTAINER_MODE`.
- Need to set option `HDF5_GENERATE_HEADERS` to `OFF`, currently in line 996 of [src/CMakeLists.txt][u11].
- Change the **release preparation branch**'s (i.e. hdf5_X_Y_Z) default configuration mode from development to production in [configure.ac][u12].
Expand All @@ -103,6 +105,7 @@ For more information on the HDF5 versioning and backward and forward compatibili
- Under `if test "X-$BUILD_MODE" = X- ; then` change `BUILD_MODE=debug` to `BUILD_MODE=production`.
- Run `sh ./autogen.sh` to regenerate the UNIX build system files and commit the changes. (use `git status --ignored` to see the changes and `git add -f` to add all files. First delete any new files not to be committed, notably `src/H5public.h~` and `autom4te.cache/`.)
- `$ git push with commit message listing change steps for creating release branch`
** END OBSOLETE CURRENTLY **
8. E-mail [email protected] to indicate that the code freeze on the release support branch (i.e. hdf5_X_Y) has been lifted and development on the next maintenance release can resume. The code freeze will remain in place on the release preparation branch (i.e. hdf5_X_Y_Z) indefinitely.

### 7. Perform Release Testing (Test Automation Team | Release Manager | Project Leads)
Expand Down
2 changes: 1 addition & 1 deletion src/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -1026,7 +1026,7 @@ set (H5_PUBLIC_GENERATED_HEADERS
${HDF5_SRC_DIR}/H5overflow.h
)

option (HDF5_GENERATE_HEADERS "Rebuild Generated Files" ON)
option (HDF5_GENERATE_HEADERS "Rebuild Generated Files" OFF)
if (HDF5_GENERATE_HEADERS)
set_source_files_properties(${H5_GENERATED_HEADERS} PROPERTIES GENERATED TRUE)
if (H5_PERL_FOUND)
Expand Down

0 comments on commit 2ac89b3

Please sign in to comment.