Fix v4l2 wrapper usage for 32 bit systems #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mismatch brakes rscam on systems with 32-bit off_t. Saw this on Ubuntu 20.04 armhf.
|
Thank you for your contribution. Does PR close #9? |
loyd
reviewed
Dec 26, 2020
I can say that I got the same error message as the reporter, and this PR resolves the root cause of my error message. But chances are good that that issue has exactly the same root cause. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
when trying out rscam on Ubuntu 20.04 armhf (Armbian on BananaPI M1), I saw that the build with standard features (i.e. with the v4l wrappers) failed to mmap, while the "no_wrapper" build worked fine (but of course could not do any format conversions). Turns out that mmap and v4l_mmap have a nasty signature mismatch that's not reflected in rscam.