Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[formal,flash_ctrl] Add connectivity check for prim_flash recov_alert #25524

Merged
merged 1 commit into from
Dec 12, 2024
Merged

[formal,flash_ctrl] Add connectivity check for prim_flash recov_alert #25524

merged 1 commit into from
Dec 12, 2024

Conversation

matutem
Copy link
Contributor

@matutem matutem commented Dec 5, 2024

Fixes #25523

@matutem matutem requested a review from a team as a code owner December 5, 2024 23:13
@matutem matutem requested review from eshapira and vogelpi and removed request for a team December 5, 2024 23:13
rswarbrick
rswarbrick reviewed Dec 6, 2024
View reviewed changes
Copy link
Contributor

@rswarbrick rswarbrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't this also need to be added to hw/top_earlgrey/formal/chip_conn_cfg.hjson?

@vogelpi
Copy link
Contributor

vogelpi commented Dec 9, 2024

I agree with @rswarbrick that this new test should probably be added to the list, too.

I've tried to run this test but it currently fails for another reason. I am investigating this with @matutem offline and will eventually report back here.

vogelpi
vogelpi approved these changes Dec 10, 2024
View reviewed changes
Copy link
Contributor

@vogelpi vogelpi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @matutem , this looks good to me!

I've edited this PR to:

  1. Add the newly added csv to the list of csvs as pointed out by Rupert.
  2. Split the source signal from the source block in the newly added csv.

If I revert the commit adding the pull-up for the POR (see #25567), the connectivity test can be run successfully. I would recommend merging this PR and take care of the pull-up issue separately.

@matutem matutem merged commit 0a016d5 into lowRISC:master Dec 12, 2024
26 of 37 checks passed
@matutem matutem deleted the flash_ctrl_conn branch December 12, 2024 00:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rswarbrick rswarbrick rswarbrick left review comments

@vogelpi vogelpi vogelpi approved these changes

@eshapira eshapira Awaiting requested review from eshapira eshapira is a code owner automatically assigned from lowRISC/ot-dv-reviewers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[formal,flash_ctrl] Add connectivity check for prim_flash recov_alert
3 participants
@matutem @vogelpi @rswarbrick