Update HiGHS to v1.8.0 #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prepare for updating HiGHS version to latest (uses a CMake command of newer cmake version)
and adapt build script to changed build variables
only significant change (apart from formatting) is the `test_empty_model` test: HiGHS v1.8.0 now treats "blah blah not a good file" as an error. To test an empty model the test was changed to a valid empty model.
- update emskripten version - update all used actions to their latest versions
add all options + documentation up until https://github.com/ERGO-Code/HiGHS/blob/v1.8.0/src/lp_data/HighsOptions.h#L1123
|
really cool, thanks ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes the following:
To make it work, the following additional changes were made:
Continuousif no type is parsed from the output (HiGHS v1.8.0 does not include "type" column if all model variables are continuous)test_empty_modelcaused HiGHS v1.8.0 to (correctly) throw a model read error. The test was updated to test against a valid empty model (the objective function being a constant).If desired, the
test_empty_modeltest can also be modified to assure that a model ofblah blah not a good filethrows a read error, but since there is already a test for invalid files i chose to modify it to test a valid empty model instead.The option typings update does not fix #31 (yet) since those come below https://github.com/ERGO-Code/HiGHS/blob/v1.8.0/src/lp_data/HighsOptions.h#L1123 (where i stopped adding option typings for now).
Maybe if i find the time, i will also add typings for all advanced options.