Skip to content

Commit

Permalink
Prep patch release to CRAN
Browse files Browse the repository at this point in the history
  • Loading branch information
louisaslett committed Sep 25, 2024
1 parent 55d309c commit cd2372f
Show file tree
Hide file tree
Showing 7 changed files with 46 additions and 42 deletions.
1 change: 1 addition & 0 deletions .Rbuildignore
Original file line number Diff line number Diff line change
Expand Up @@ -6,3 +6,4 @@ LICENSE
^R/hex\.R$
^inst/.*\.png$
^CRAN-SUBMISSION$
^revdep$
47 changes: 5 additions & 42 deletions cran-comments.md
Original file line number Diff line number Diff line change
@@ -1,46 +1,9 @@
## Response to review 1

Thank you for the thorough review of the package. I have carefully gone through and addressed each point, with only 1 item not address (reason given) and 1 item I cannot identify (explained below).

> Please omit the redundant "Tools for" at the start of your title and description.
I have removed these words from the title and reworded the description in response to this and the following issue.

> If there are references describing the methods in your package, please add these in the description field of your DESCRIPTION file in the form
> authors (year) <doi:...>
> authors (year) <arXiv:...>
> authors (year, ISBN:...)
> or if those are not available: <[https:...]https:...>
> with no space after 'doi:', 'arXiv:', 'https:' and angle brackets for auto-linking. (If you want to add a title as well please put it in quotes: "Title")
Key references have been added to the description in the format requested.

> You write information messages to the console that cannot be easily suppressed.
> It is more R like to generate objects that can be used to extract the information a user is interested in, and then print() that object.
> Instead of print()/cat() rather use message()/warning() or if(verbose)cat(..) (or maybe stop()) if you really have to write text to the console. (except for print, summary, interactive functions)
> -> R/CoherentNetworksOfOrder.R; R/CoherentSystemsOfOrder.R; R/ComputeSignature.R; R/MaskedLifetimeInference.R; R/nonParBayesSystemInferencePriorSetsTEST.R
`cat()` has been changed to `message()` in R/CoherentNetworksOfOrder.R and R/CoherentSystemsOfOrder.R. I have also changed it in R/nonParBayesSystemInferencePriorSetsTEST.R although this file is only present for historical archiving and not exported in the namespace.

The only place I have not made the change is in R/ComputeSignature.R. This is because, per the documentation for this function, `cat()` is only used if `frac = TRUE`. The documentation states that (added star emphasis mine):

\item{frac}{if TRUE then the function **prints out** signature elements as fractions **rather than returning** a decimal signature vector}

I hope this is acceptable.

> Please ensure that you do not use more than 2 cores in your examples, vignettes, etc.
> -> nonParBayesSystemInferencePriorSets-R files
I have looked at this help file multiple times and cannot see where we use more than 1 core. There are multiple references to `cores = 1` (which I did because I was already aware of this rule). I have also monitored the output of `top` during a full R CMD CHECK and it does not exceed 100% of a single core. If the issue persists, please could you let me know where you see more than 1 core specified and I'm happy to fix?

## Comments (submission)
## R CMD check results

* I am hoping to return this package to CRAN. It was archived due to a dependency {PhaseType} being removed from CRAN, but {PhaseType} is now back on CRAN.
* I have moved institution since last updating this package, hence the maintainer email address has changed.
* I have tried to go through as carefully as possible changes to CRAN policy since last submission leading to many changes, apologies if I have missed anything.
0 errors | 0 warnings | 0 notes

## R CMD check results
* This is a small patch release primarily to fix a new NOTE which appears for the current r-devel, due to \link{} targets that are outside the current package not being anchored.

0 errors | 0 warnings | 1 note
## revdepcheck results

The note relates to this being a new submission on CRAN due to prior archiving.
There are no reverse dependencies.
7 changes: 7 additions & 0 deletions revdep/.gitignore
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
checks
library
checks.noindex
library.noindex
cloud.noindex
data.sqlite
*.html
24 changes: 24 additions & 0 deletions revdep/README.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
# Platform

|field |value |
|:--------|:------------------------------------------|
|version |R version 4.4.1 (2024-06-14) |
|os |macOS Sonoma 14.6.1 |
|system |aarch64, darwin20 |
|ui |RStudio |
|language |(EN) |
|collate |en_US.UTF-8 |
|ctype |en_US.UTF-8 |
|tz |Europe/London |
|date |2024-09-25 |
|rstudio |2024.09.0+375 Cranberry Hibiscus (desktop) |
|pandoc |NA |

# Dependencies

|package |old |new |Δ |
|:-----------------|:-----|:-----|:--|
|ReliabilityTheory |0.3.0 |0.3.1 |* |

# Revdeps

7 changes: 7 additions & 0 deletions revdep/cran.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
## revdepcheck results

We checked 0 reverse dependencies, comparing R CMD check results across CRAN and dev versions of this package.

* We saw 0 new problems
* We failed to check 0 packages

1 change: 1 addition & 0 deletions revdep/failures.md
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
*Wow, no problems at all. :)*
1 change: 1 addition & 0 deletions revdep/problems.md
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
*Wow, no problems at all. :)*

0 comments on commit cd2372f

Please sign in to comment.