Merge pull request #136 from technosf/development

Changes ordering of HeaderBar update to get cleaner ico transition
louis77 · Oct 13, 2024 · f6cb437 · f6cb437
2 parents 58f748e + dfa1dee
commit f6cb437
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/.gitignore b/.gitignore
@@ -7,3 +7,4 @@ build-aux
 .flatpak-builder
 code.sh
 favicon.ico
+tuner.code-workspace
diff --git a/src/Widgets/HeaderBar.vala b/src/Widgets/HeaderBar.vala
@@ -190,13 +190,13 @@ public class Tuner.HeaderBar : Gtk.HeaderBar {
         if (_station != null) {
             _station.notify.disconnect (handle_station_change);
         }
+        load_favicon (station); // Kick off first as its async and long running in comparison
         _station = station;
         _station.notify.connect ( (sender, property) => {
             handle_station_change ();
         });
         title = station.title;
         subtitle = _("Playing");
-        load_favicon (station); 
         starred = station.starred;
     }
 
@@ -268,6 +268,7 @@ public class Tuner.HeaderBar : Gtk.HeaderBar {
      */
     private void load_favicon(Model.Station station)
     {
+        this.favicon.clear ();
         Favicon.load_async.begin (station, true, (favicon, res) => {
             var pxbuf = Favicon.load_async.end (res);
             if (pxbuf != null) {