Merge pull request #79 from lotteon2/hotfix/review-list

fix: amend review list
lotteon2 · Jan 11, 2024 · b350b3f · b350b3f
2 parents 277cb82 + cb705bc
commit b350b3f
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 6 deletions.
diff --git a/src/main/java/kr/bb/product/common/aop/LoggingHandler.java b/src/main/java/kr/bb/product/common/aop/LoggingHandler.java
@@ -9,7 +9,6 @@
 import org.aspectj.lang.annotation.Aspect;
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
-import org.springframework.beans.factory.annotation.Value;
 import org.springframework.stereotype.Component;
 import org.springframework.web.context.request.RequestAttributes;
 import org.springframework.web.context.request.RequestContextHolder;
@@ -18,10 +17,8 @@
 @Aspect
 @Component
 public class LoggingHandler {
-  private static final Logger logger = LoggerFactory.getLogger(LoggingHandler.class);
 
-  @Value("${spring.config.active.on-profile:local}")
-  private String activeProfile;
+  private static final Logger logger = LoggerFactory.getLogger(LoggingHandler.class);
 
   @Around("within(kr.bb.product.domain..*)")
   public Object logging(ProceedingJoinPoint pjp) throws Throwable {

diff --git a/src/main/java/kr/bb/product/domain/review/application/port/in/ReviewQueryInputPort.java b/src/main/java/kr/bb/product/domain/review/application/port/in/ReviewQueryInputPort.java
@@ -1,6 +1,5 @@
 package kr.bb.product.domain.review.application.port.in;
 
-import bloomingblooms.errors.EntityNotFoundException;
 import java.util.List;
 import java.util.Map;
 import java.util.stream.Collectors;
@@ -54,7 +53,7 @@ public ReviewCommand.StoreReviewList findReviewByStoreId(
     Pageable pageRequest = getPageable(pageable, sortOption);
 
     List<Product> productByStoreId = productQueryOutPort.findProductByStoreId(storeId);
-    if (productByStoreId.isEmpty()) throw new EntityNotFoundException();
+    if (productByStoreId.isEmpty()) return null;
     List<String> productId =
         productByStoreId.stream().map(Product::getProductId).collect(Collectors.toList());