Make Test adapter constructor able to receive stubs as a keyword argument #1597
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR makes Test adapter constructor able to receive
stubs
as a keyword argument.Details
The Test adapter expects to receive the
stubs
as a positional argument. It is great because in the most of cases we want to use it likeBut it is not compatible with
Faraday.default_adapter_options
as it must to be a hash.faraday/lib/faraday/rack_builder.rb
Lines 72 to 76 in 59c5003
So we can't do something like
I changed the Test adapter constructor to also accept positional argument instead of change
RackBuilder::Handler#builder
method because the way to pass options to adapters is using hash.