Add json as an explicit dependency #1589
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is similar to #1573, but for
json
.In this case, I'm not getting a warning about
json
but aboutostruct
, i.e., it's notjson
that's being removed as a default gem in Ruby 3.5, butostruct
:ostruct
is getting loaded byjson
though, andjson
is getting loaded byfaraday
.json
has fixed the problem by autoloading the class that usesostruct
at ruby/json@b507f9e. However, I can't really pick up the fix, sincejson
is not a explicit dependency offaraday
, so the default version of it always get loaded.So the only thing remaining to fix the issue would be for
faraday
to declare its dependency onjson
. That way, Bundler will be aware of the dependency and abundle update json
can be used to pick up ajson
version that does not loadostruct
and thus avoid the warning.