Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #551 Allows user passwords with accolade #552

Merged
merged 2 commits into from
Mar 22, 2024

Conversation

ArnaudB88
Copy link

No description provided.

@pwelter34
Copy link
Member

thanks for working on this. I'm thinking a simpler solution might be to just make connection string not resolve variables. I don't see any reason you'd want that.

Fix ...

Old Code, resolves variables in the underlying value.

public string ConnectionString
{
    get => GetProperty();
    set => SetProperty(value);
}

New Code, just use value as is

public string ConnectionString { get; set; }

thoughts?
~ Paul

@pwelter34 pwelter34 merged commit 0e558a5 into loresoft:master Mar 22, 2024
1 check passed
@ArnaudB88
Copy link
Author

@pwelter34 That is indeed a much simpler and cleaner solution 👍

@ArnaudB88 ArnaudB88 deleted the bug/551-Connectionstring branch March 26, 2024 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants