Skip to content

Commit

Permalink
buildRosPackage: reasons for building ament_python as we do
Browse files Browse the repository at this point in the history
  • Loading branch information
lopsided98 committed Sep 7, 2023
1 parent ed8b9e6 commit 3163a7a
Showing 1 changed file with 4 additions and 2 deletions.
6 changes: 4 additions & 2 deletions distros/build-ros-package/default.nix
Original file line number Diff line number Diff line change
Expand Up @@ -31,10 +31,12 @@ else stdenv.mkDerivation) (args // {
} // lib.optionalAttrs (buildType == "ament_python") {
dontUseCmakeConfigure = true;

# Modelled after colcon.
# Modeled after colcon.
# As of 0.12.1, colcon uses the legacy distutils install.py script, so we do
# the same. Using modern techniques, such as "pip install" with setuptools,
# causes issues due to differences in setup.cfg interpretation.
# causes issues due to differences in setup.cfg interpretation. In particular,
# it ignores the "install-scripts" directive, which is commonly used in ROS
# to install binaries to "$out/lib/<package name>".
# https://github.com/colcon/colcon-core/blob/0.12.1/colcon_core/task/python/build.py#L84
format = "other";

Expand Down

0 comments on commit 3163a7a

Please sign in to comment.