Refactor encodings #2145
Draft
Refactor encodings #2145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was an encoding issue in fileinfoname() that prevented finding files with special characters in the path (fc_stat would fail). Rewrite it using Qt APIs only. Closes longturn#565.
This prevents encoding issues. See longturn#565.
Use QFileInfo. This removes the need to encode the file name in the system locale by hand. See longturn#565.
QFile() provides an API that doesn't require dangerous explicit encoding conversions. See longturn#565.
We need only two character encodings: whatever the local 8-bits encoding is and UTF-8. QString provides native conversion between those so we don't need anything of our own. This also fully removes traces of past support for custom internal and data encodings -- why would anyone want this now that UTF-8 has finally taken over the world? See longturn#565.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR tries to sanitize the handling of character encodings:
Checks
I checked the following under
winefor files with accents in the name:-roption, and from the client)I couldn't check the following because the file names don't have accents in my setup: