Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: add kb for instance manager restarted and make volume unstable #1023

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

docs: add kb for instance manager restarted and make volume unstable #1023

wants to merge 1 commit into from

Conversation

ChanYiLin
Copy link
Contributor

ref: longhorn/longhorn#9851
add kb for instance manager restarted and make volume unstable

@ChanYiLin ChanYiLin self-assigned this Dec 12, 2024
@ChanYiLin ChanYiLin requested a review from a team as a code owner December 12, 2024 09:11
@ChanYiLin ChanYiLin mentioned this pull request Dec 12, 2024
Closed
@netlify Netlify
Copy link

netlify bot commented Dec 12, 2024 •
edited
Loading

✅ Deploy Preview for longhornio ready!

Name Link
🔨 Latest commit f321fff
🔍 Latest deploy log https://app.netlify.com/sites/longhornio/deploys/6789fe5addc52a000829518e
😎 Deploy Preview https://deploy-preview-1023--longhornio.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

This was referenced Dec 12, 2024
Closed
Closed
@ChanYiLin ChanYiLin force-pushed the LH9851_add_KB_for_im_pod_restarting_iscsi_connection_error branch from e0119bf to 5747b46 Compare December 12, 2024 09:25
innobead
innobead requested changes Dec 12, 2024
View reviewed changes
Copy link
Member

@innobead innobead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technically, LGTM. Just a few suggestions.

content/kb/troubleshooting-instance-manager-pods-are-restarted.md Outdated Show resolved Hide resolved
WebberHuang1118
WebberHuang1118 previously approved these changes Dec 12, 2024
View reviewed changes
Copy link

@WebberHuang1118 WebberHuang1118 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

jhkrug
jhkrug requested changes Dec 16, 2024
View reviewed changes
Copy link
Contributor

@jhkrug jhkrug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor suggestions for your consideration. Thank you.

content/kb/troubleshooting-instance-manager-pods-are-restarted.md Outdated Show resolved Hide resolved
content/kb/troubleshooting-instance-manager-pods-are-restarted.md Outdated Show resolved Hide resolved
content/kb/troubleshooting-instance-manager-pods-are-restarted.md Outdated Show resolved Hide resolved
content/kb/troubleshooting-instance-manager-pods-are-restarted.md Outdated Show resolved Hide resolved
@ChanYiLin ChanYiLin force-pushed the LH9851_add_KB_for_im_pod_restarting_iscsi_connection_error branch from 5747b46 to 5a67328 Compare December 23, 2024 09:36
@ChanYiLin
Copy link
Contributor Author

Hi @innobead @jhkrug
Thanks for the feedbacks.
Please take a look, thanks

innobead
innobead previously approved these changes Dec 23, 2024
View reviewed changes
jillian-maroket
jillian-maroket reviewed Jan 16, 2025
View reviewed changes
Copy link
Contributor

@jillian-maroket jillian-maroket left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review done

Note: I just noticed that this has already been reviewed by longhorn/doc. Feel free apply whatever suggestions make sense.

content/kb/troubleshooting-instance-manager-pods-are-restarted.md Outdated Show resolved Hide resolved
content/kb/troubleshooting-instance-manager-pods-are-restarted.md Outdated Show resolved Hide resolved
content/kb/troubleshooting-instance-manager-pods-are-restarted.md Outdated Show resolved Hide resolved
content/kb/troubleshooting-instance-manager-pods-are-restarted.md Outdated Show resolved Hide resolved
content/kb/troubleshooting-instance-manager-pods-are-restarted.md Outdated Show resolved Hide resolved
content/kb/troubleshooting-instance-manager-pods-are-restarted.md Outdated Show resolved Hide resolved
content/kb/troubleshooting-instance-manager-pods-are-restarted.md Outdated Show resolved Hide resolved
content/kb/troubleshooting-instance-manager-pods-are-restarted.md Outdated Show resolved Hide resolved
content/kb/troubleshooting-instance-manager-pods-are-restarted.md Outdated Show resolved Hide resolved
@derekbit
Copy link
Member

We can merge the doc after addressing the comments. @ChanYiLin

@derekbit derekbit force-pushed the LH9851_add_KB_for_im_pod_restarting_iscsi_connection_error branch from 294a68a to 716c278 Compare January 17, 2025 03:27
@ChanYiLin ChanYiLin dismissed stale reviews from innobead and WebberHuang1118 via b5a9efd January 17, 2025 05:08
@ChanYiLin ChanYiLin force-pushed the LH9851_add_KB_for_im_pod_restarting_iscsi_connection_error branch from 716c278 to b5a9efd Compare January 17, 2025 05:08
@derekbit derekbit force-pushed the LH9851_add_KB_for_im_pod_restarting_iscsi_connection_error branch from b5a9efd to f321fff Compare January 17, 2025 06:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhkrug jhkrug jhkrug requested changes

@jillian-maroket jillian-maroket jillian-maroket approved these changes

@derekbit derekbit derekbit approved these changes

@WebberHuang1118 WebberHuang1118 WebberHuang1118 left review comments

@innobead innobead innobead left review comments

@james-munson james-munson Awaiting requested review from james-munson

Requested changes must be addressed to merge this pull request.

Assignees

@ChanYiLin ChanYiLin

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@ChanYiLin @derekbit @innobead @jhkrug @WebberHuang1118 @jillian-maroket