Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added Switch trait for enums, Sensor is Copy and Clone #11

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

added Switch trait for enums, Sensor is Copy and Clone #11

wants to merge 1 commit into from

Conversation

nebelgrau77
Copy link
Contributor

OK, going step by step this time: just the Switch trait for enums, and Copy and Clone for Sensor.

lonesometraveler
lonesometraveler requested changes Jun 16, 2022
View reviewed changes
Copy link
Owner

@lonesometraveler lonesometraveler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I hear "Switch," I think about switch devices (push, toggle, rotary, etc.). Let's use BitFlag unless you have a better idea.

I made Sensor Copy and Clone in a separate PR.

@nebelgrau77
Copy link
Contributor Author

OK, I'll change it back to BitFlag. Maybe it's not such a big deal: the users will only interact with the Flag enum, so there shouldn't be any confusion between that and the BitFlag.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lonesometraveler lonesometraveler lonesometraveler requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nebelgrau77 @lonesometraveler